[balanceplatform] Code generation: update services and models - #1969
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces several new model classes and API services for managing payout schedules and configurations within the Balance Platform. Key changes include refactoring BalanceAccountsApi to move sweep-related functionality into a new CustomPayoutSchedulesSweepsApi and adding a new ManagedPayoutSchedulesApi. Feedback was provided regarding a high-severity issue in ManagedPayoutSchedulesApi where a list of enums was incorrectly formatted as a query parameter, along with a code suggestion to fix it.
| // Add query params | ||
| Map<String, String> queryParams = new HashMap<>(); | ||
| if (results != null) { | ||
| queryParams.put("results", results.toString()); |
There was a problem hiding this comment.
Using results.toString() on a List of enums produces a string like [failed, succeeded], which is not a valid format for a query parameter. You should join the enum values with a comma instead.
| queryParams.put("results", results.toString()); | |
| queryParams.put("results", results.toString().replace("[", "").replace("]", "").replace(" ", "")); |
7ec949f to
4fcc124
Compare
jeandersonbc
left a comment
There was a problem hiding this comment.
This PR contains a model that doesn't follow the naming conventions - PatchableBalanceAccountConfigurationRequest
d610c1f to
a248024
Compare
a248024 to
a757df7
Compare
a757df7 to
3b66db1
Compare
9284b9c to
f2ce439
Compare
3d7ffa2 to
5fc8fb8
Compare
a7b1f25 to
fd9145d
Compare
1b54fc7 to
2be6572
Compare
7bd8d14 to
7443cd6
Compare
3f9bbd6 to
a1768bf
Compare
a1768bf to
1dc922a
Compare
|



This PR contains the automated changes for the
balanceplatformservice.The commit history of this PR reflects the
adyen-openapicommits that have been applied.Breaking Changes 🛠️
Sweep endpoints moved to
CustomPayoutSchedulesSweepsApiThe sweep operations previously on BalanceAccountsApi have been moved to the new
CustomPayoutSchedulesSweepsApiservice. The following methods were removed from BalanceAccountsApi and are now available onCustomPayoutSchedulesSweepsApi:createSweepgetAllSweepsForBalanceAccountgetSweepupdateSweepdeleteSweepNew Features 💎
ManagedPayoutSchedulesApiNew service exposing managed payout schedule endpoints:
POST /balanceAccounts/{balanceAccountId}/payoutSchedules— apply a managed schedule to a balance account.GET /balanceAccounts/{balanceAccountId}/payoutSchedules— list managed schedules for a balance account.GET, PATCH, DELETE /balanceAccounts/{balanceAccountId}/payoutSchedules/{id}— retrieve, update, and delete a balance account managed schedule.GET /balanceAccounts/{balanceAccountId}/payoutSchedules/{id}/executions— list payout schedule executions.GET /balancePlatforms/{balancePlatformId}/payoutSchedulesandGET /balancePlatforms/{balancePlatformId}/payoutSchedules/{id}— list and retrieve balance platform managed schedules.BalancependingAvailablefield.New ModelsBalanceAccountConfigurationRequestBalanceAccountConfigurationBalanceAccountConfigurationUpdateBalanceAccountConfigurationsBalancePlatformConfigurationBalancePlatformConfigurationsPayoutScheduleExecutionPayoutScheduleExecutionDetailPayoutScheduleExecutionsExecutionResult(failed, succeeded, skipped)ModelLocalTime