Skip to content

Test spotless check - #1960

Closed
jeandersonbc wants to merge 2 commits into
mainfrom
test-spotless-check
Closed

Test spotless check#1960
jeandersonbc wants to merge 2 commits into
mainfrom
test-spotless-check

Conversation

@jeandersonbc

Copy link
Copy Markdown
Contributor

Description

Tested scenarios

Fixed issue:

@jeandersonbc
jeandersonbc requested a review from a team as a code owner May 15, 2026 07:32

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the Client instantiation in BalanceControlTest.java into a single line. The reviewer noted that this change exceeds the 100-character line limit and recommended using a more concise constructor to improve readability and maintain consistency with the rest of the codebase.

.apiKey("test")
.environment(Environment.TEST)
.liveEndpointUrlPrefix("myCompany"));
Client client = new Client(new Config().apiKey("test").environment(Environment.TEST).liveEndpointUrlPrefix("myCompany"));

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The single-line instantiation of Client and Config is difficult to read and exceeds the standard 100-character line limit (this line is 114 characters). It is also inconsistent with the formatting used elsewhere in this file (e.g., lines 38-43). Using the more concise Client constructor is recommended to improve readability and maintain consistency.

Suggested change
Client client = new Client(new Config().apiKey("test").environment(Environment.TEST).liveEndpointUrlPrefix("myCompany"));
Client client = new Client("test", Environment.TEST, "myCompany");
References
  1. The Google Java Style Guide recommends a column limit of 100 characters to ensure code readability. (link)

@jeandersonbc

Copy link
Copy Markdown
Contributor Author

Closing Pull Request - this was just for testing purposes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant