[recurring] Code generation: update services and models - #1768
[recurring] Code generation: update services and models#1768AdyenAutomationBot wants to merge 1 commit into
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces an automated update to the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request refactors several model classes by moving them from the com.adyen.model.recurring package to com.adyen.model.java. This appears to be an effort to create a shared model layer. While most files have been correctly moved and updated, a critical issue was found in JSON.java. Its package was changed, but the file was not moved to the corresponding directory, which will break the build. I've added a specific comment on this file. It's also worth noting that other parts of the codebase that depend on these moved models might need to be updated to use the new package, which doesn't seem to be part of this PR.
| @@ -1,4 +1,4 @@ | |||
| package com.adyen.model.recurring; | |||
| package com.adyen.model.java; | |||
There was a problem hiding this comment.
The package declaration has been updated to com.adyen.model.java, but the file itself has not been moved from src/main/java/com/adyen/model/recurring/ to src/main/java/com/adyen/model/java/. In Java, the directory structure must match the package structure. This mismatch will cause a compilation error. The file needs to be moved to the correct directory.
This PR contains the automated changes for the
recurringservice.The commit history of this PR reflects the
adyen-openapicommits that have been applied.