Code generation: update services and models - #1574
Conversation
08da4f7 to
6d3008b
Compare
Summary of ChangesHello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the SDK's generated models based on recent modifications to the OpenAPI specifications. The changes primarily introduce new Strong Customer Authentication (SCA) features and expand support for various local bank account identification types within the balance platform API. Additionally, numerous model files have received general code hygiene improvements, including formatting, import organization, and Javadoc refinements. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request contains auto-generated updates to services and models. The changes are mostly stylistic, including formatting, indentation, and Javadoc updates. While the code is functionally correct, there's a recurring Javadoc formatting issue across many of the generated model classes where the Javadoc comment block starter /** is not on its own line. This affects readability and deviates from standard Java conventions. I've added a few comments to highlight this pattern, which seems to be a bug in the code generator.
| } | ||
|
|
||
| /** | ||
| /** |
There was a problem hiding this comment.
The Javadoc for fromJson has a formatting issue. The /** should be on its own line and properly indented for better readability and to adhere to standard Java coding conventions. This issue appears to be present in many of the generated model classes in this pull request.
| * | ||
| * @return JSON string | ||
| */ | ||
| /** |
There was a problem hiding this comment.
Similar to the fromJson method, the Javadoc for toJson has a formatting issue. The /** should start on a new line. This seems to be a recurring issue in the generated code.
| } | ||
|
|
||
| /** | ||
| /** |
There was a problem hiding this comment.
The Javadoc for fromJson has a formatting issue. The /** should be on its own line and properly indented for better readability and to adhere to standard Java coding conventions.
| * | ||
| * @return JSON string | ||
| */ | ||
| /** |
There was a problem hiding this comment.
Similar to the fromJson method, the Javadoc for toJson has a formatting issue. The /** should start on a new line.
| } | ||
|
|
||
| /** | ||
| /** |
There was a problem hiding this comment.
The Javadoc for fromJson has a formatting issue. The /** should be on its own line and properly indented for better readability and to adhere to standard Java coding conventions.
| * | ||
| * @return JSON string | ||
| */ | ||
| /** |
There was a problem hiding this comment.
Similar to the fromJson method, the Javadoc for toJson has a formatting issue. The /** should start on a new line.
| } | ||
|
|
||
| /** | ||
| /** |
There was a problem hiding this comment.
The Javadoc for fromJson has a formatting issue. The /** should be on its own line and properly indented for better readability and to adhere to standard Java coding conventions. This issue appears to be present in many of the generated model classes in this pull request.
| * | ||
| * @return JSON string | ||
| */ | ||
| /** |
There was a problem hiding this comment.
Similar to the fromJson method, the Javadoc for toJson has a formatting issue. The /** should start on a new line. This seems to be a recurring issue in the generated code.
| return o.toString().replace("\n", "\n "); | ||
| } | ||
|
|
||
| /** |
There was a problem hiding this comment.
The Javadoc for fromJson has a formatting issue. The /** should be on its own line and properly indented for better readability and to adhere to standard Java coding conventions. This issue appears to be present in many of the generated model classes in this pull request.
| public static ApproveAssociationRequest fromJson(String jsonString) throws JsonProcessingException { | ||
| return JSON.getMapper().readValue(jsonString, ApproveAssociationRequest.class); | ||
| } | ||
| /** |
There was a problem hiding this comment.
Similar to the fromJson method, the Javadoc for toJson has a formatting issue. The /** should start on a new line. This seems to be a recurring issue in the generated code.
cc00022 to
81e3569
Compare
2 participants
Management API
Add
CardRegionEnumenums inSplitConfigurationRuleclassOpenAPI spec files or templates have been modified on 09-10-2025 by commit.