Skip to content

Code generation: update services and models - #1571

Closed
AdyenAutomationBot wants to merge 2 commits into
mainfrom
sdk-automation/models
Closed

Code generation: update services and models#1571
AdyenAutomationBot wants to merge 2 commits into
mainfrom
sdk-automation/models

Conversation

@AdyenAutomationBot

@AdyenAutomationBot AdyenAutomationBot commented Oct 6, 2025

Copy link
Copy Markdown
Collaborator

OpenAPI spec files or templates have been modified on 09-10-2025 by commit.

@AdyenAutomationBot
AdyenAutomationBot requested a review from a team as a code owner October 6, 2025 11:55
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request delivers an automated update to the Adyen services and models, reflecting recent modifications to the OpenAPI specification. The changes span across multiple packages, focusing on maintaining alignment with the latest API definitions, improving code consistency through reformatting, and introducing new capabilities for Strong Customer Authentication associations.

Highlights

  • OpenAPI Specification Update: The pull request incorporates the latest changes from the OpenAPI specification, ensuring all services and models are up-to-date with the most recent API definitions.
  • New SCA Association Models: New models related to Strong Customer Authentication (SCA) associations have been introduced within the balanceplatform package, enhancing functionality for managing SCA devices and entities.
  • Code Formatting and Standardization: Numerous files across acswebhooks, balancecontrol, and balanceplatform packages have undergone consistent reformatting, including import statement reordering and Javadoc comment adjustments, to improve code readability and maintainability.
  • Improved oneOf Schema Handling: The BankAccountAccountIdentification.java file in the balanceplatform package has been significantly refactored to enhance the handling of oneOf schemas, leading to more robust deserialization logic.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request appears to be an automated code generation based on an updated OpenAPI specification. The changes primarily consist of formatting adjustments, such as indentation and line breaks, and the addition of new model classes.

My review focuses on a couple of areas for improvement:

  • In AcsWebhooksHandler, I've suggested simplifying some methods for better readability and conciseness by using Optional.filter().
  • Across many of the generated model files, there are malformed Javadoc comments for fromJson and toJson methods. I've provided a fix for one file as an example, and this should be applied to all similar cases to ensure proper documentation generation.

Overall, the changes are consistent with what's expected from a code generator update.

@AdyenAutomationBot
AdyenAutomationBot force-pushed the sdk-automation/models branch 2 times, most recently from 9ac6724 to 250d70b Compare October 7, 2025 07:42
@AdyenAutomationBot
AdyenAutomationBot requested a review from a team as a code owner October 7, 2025 07:42
@AdyenAutomationBot
AdyenAutomationBot force-pushed the sdk-automation/models branch 3 times, most recently from ee4c537 to 5d206fa Compare October 9, 2025 11:50
@gcatanese gcatanese closed this Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants