Skip to content

Code generation: update services and models - #1524

Merged
gcatanese merged 2 commits into
mainfrom
sdk-automation/models
Jul 23, 2025
Merged

Code generation: update services and models#1524
gcatanese merged 2 commits into
mainfrom
sdk-automation/models

Conversation

@AdyenAutomationBot

@AdyenAutomationBot AdyenAutomationBot commented Jul 18, 2025

Copy link
Copy Markdown
Collaborator

OpenAPI spec files or templates have been modified on 23-07-2025 by commit.

Checkout API

  • Add attribute enhancedSchemeData (Enhanced scheme data that may be required for processing the payment) in PaymentAmountUpdateRequest, PaymentCancelRequest, PaymentRefundRequest, PaymentReversalRequest, StandalonePaymentCancelRequest
  • Add enum values Payme and PaymePos in PaymentDetails
  • Add attribute promoted in PaymentMethod
  • Add attribute subtype in RivertyDetails

@AdyenAutomationBot
AdyenAutomationBot requested a review from a team as a code owner July 18, 2025 09:31

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request delivers an automated update to the codebase's generated services and models. While primarily consisting of stylistic reformatting, it includes a crucial functional enhancement to improve the handling of polymorphic bank account identification data, ensuring more accurate and robust deserialization.

Highlights

  • Automated Code Generation Update: This pull request is an automated update of generated services and models, likely reflecting changes in the underlying OpenAPI specification files.
  • Code Reformatting: The vast majority of changes across numerous files involve reformatting of Javadoc comments, method signatures, import statements, and whitespace. These changes are cosmetic and do not alter the functional behavior of the code.
  • Polymorphic Deserialization Improvement: A significant functional change was implemented in src/main/java/com/adyen/model/balanceplatform/BankAccountAccountIdentification.java to correctly handle polymorphic bank account identification types using oneOf schema composition. This was achieved by extending AbstractOpenApiSchema and introducing a custom Jackson serializer/deserializer, enhancing the robustness of data deserialization.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates services and models based on modifications to OpenAPI specifications. The changes are largely auto-generated, focusing on formatting and minor code style adjustments.

While the changes are mostly stylistic, I've identified a few areas for improvement that could enhance maintainability and correctness across the generated code:

  1. Redundant Logic: In AcsWebhooksHandler, the logic for verifying enum types can be simplified.
  2. Malformed Javadocs: There's a recurring issue with malformed Javadoc comments for fromJson and toJson methods across many model classes, which could impact documentation generation.
  3. Code Simplification: The isNullable() method in AbstractOpenApiSchema can be made more concise.

Addressing these in the generator templates would improve the quality of future auto-generated code.

@gcatanese
gcatanese merged commit efb9c9b into main Jul 23, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants