Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .editorconfig

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some dependencies have been modified in this PR, review the modifications in the comments before merging.

Original file line number Diff line number Diff line change
Expand Up @@ -479,6 +479,7 @@ ktlint_standard_function-signature = disabled
ktlint_function_naming_ignore_when_annotated_with = Composable
ktlint_standard_function-expression-body = disabled
ktlint_standard_class-signature = disabled
ktlint_standard_blank-line-between-when-conditions = disabled
max_line_length = 120
ij_kotlin_align_in_columns_case_branch = false
ij_kotlin_align_multiline_binary_operation = false
Expand Down
3 changes: 3 additions & 0 deletions .github/release_notes_dependency_list.toml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
"androidx.compose:compose-bom" = "[AndroidX Compose BoM](https://developer.android.com/develop/ui/compose/bom/bom-mapping)"
"androidx.constraintlayout:constraintlayout" = "[AndroidX ConstraintLayout](https://developer.android.com/jetpack/androidx/releases/constraintlayout#{})"
"androidx.fragment:fragment-ktx" = "[AndroidX Fragment](https://developer.android.com/jetpack/androidx/releases/fragment#{})"
"androidx.lifecycle:lifecycle-runtime-compose" = "[AndroidX Lifecycle Runtime Compose](https://developer.android.com/jetpack/androidx/releases/lifecycle#{})"
"androidx.lifecycle:lifecycle-runtime-ktx" = "[AndroidX Lifecycle Runtime](https://developer.android.com/jetpack/androidx/releases/lifecycle#{})"
"androidx.lifecycle:lifecycle-viewmodel-compose" = "[AndroidX Lifecycle ViewModel Compose](https://developer.android.com/jetpack/androidx/releases/lifecycle#{})"
"androidx.lifecycle:lifecycle-viewmodel-ktx" = "[AndroidX Lifecycle ViewModel](https://developer.android.com/jetpack/androidx/releases/lifecycle#{})"
Expand Down Expand Up @@ -69,6 +70,7 @@
"jacoco" = ""
"org.bitbucket.b_c:jose4j" = ""
"org.jetbrains.dokka" = ""
"org.jetbrains.dokka-javadoc" = ""
"org.jetbrains.kotlinx.binary-compatibility-validator" = ""
"org.jetbrains.kotlinx.kover" = ""
"org.jetbrains.kotlinx:kotlinx-coroutines-test" = ""
Expand All @@ -88,3 +90,4 @@
"kotlin-parcelize" = ""
"org.jetbrains.kotlin.android" = ""
"org.jetbrains.kotlin:kotlin-parcelize-runtime" = ""
"org.jetbrains.kotlin.plugin.compose" = ""
6 changes: 3 additions & 3 deletions .github/workflows/add_pr_label.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
- 'hotfix/**'

permissions:
pull-requests: write

Check warning on line 15 in .github/workflows/add_pr_label.yml

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Move this write permission from workflow level to job level.

See more on https://sonarcloud.io/project/issues?id=Adyen_adyen-android&issues=AZ9yKL9hvSpjtQlrUjV7&open=AZ9yKL9hvSpjtQlrUjV7&pullRequest=2886

jobs:
get_label:
Expand All @@ -23,13 +23,13 @@

steps:
- name: Checkout to current branch
uses: actions/checkout@v5
uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0

- name: Get label
id: get_label
run: |
chmod +x scripts/generate_pr_label.sh
branch_name="${{github.event.pull_request.head.ref}}"

Check failure on line 32 in .github/workflows/add_pr_label.yml

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

The expression github.event.pull_request.head.ref can be set by an external actor to a specially crafted value, enabling script injection. Change this workflow to not use user-controlled data directly in a run block, for example by assigning this expression to an environment variable.

See more on https://sonarcloud.io/project/issues?id=Adyen_adyen-android&issues=AZ9yKL9hvSpjtQlrUjV6&open=AZ9yKL9hvSpjtQlrUjV6&pullRequest=2886
LABEL=$(./scripts/generate_pr_label.sh "$branch_name")
echo -e "label=$LABEL" >> $GITHUB_OUTPUT
echo -e $LABEL
Expand All @@ -40,10 +40,10 @@

steps:
- name: Checkout to current branch
uses: actions/checkout@v5
uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0

- name: Add label
uses: actions/github-script@v8
uses: actions/github-script@3a2844b7e9c422d3c10d287c895573f7108da1b3 # v9.0.0
env:
LABEL: ${{ needs.get_label.outputs.label }}
with:
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/assemble.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,16 +14,16 @@ jobs:
labels: ubuntu-latest-8-cores

steps:
- uses: actions/checkout@v5
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0

- name: Set up JDK
uses: actions/setup-java@v5
uses: actions/setup-java@1bcf9fb12cf4aa7d266a90ae39939e61372fe520 # v5.4.0
with:
distribution: 'zulu'
java-version: 17

- name: Gradle cache
uses: gradle/actions/setup-gradle@v4
uses: gradle/actions/setup-gradle@3f131e8634966bd73d06cc69884922b02e6faf92 # v6.2.0
with:
cache-read-only: false

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v5
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0

- name: Set up JDK
uses: actions/setup-java@v5
uses: actions/setup-java@1bcf9fb12cf4aa7d266a90ae39939e61372fe520 # v5.4.0
with:
distribution: 'zulu'
java-version: 17
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/check_dependency_changes.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
workflow_call:

permissions:
contents: write

Check warning on line 7 in .github/workflows/check_dependency_changes.yml

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Move this write permission from workflow level to job level.

See more on https://sonarcloud.io/project/issues?id=Adyen_adyen-android&issues=AZ9yKL9GvSpjtQlrUjV2&open=AZ9yKL9GvSpjtQlrUjV2&pullRequest=2886
pull-requests: write

Check warning on line 8 in .github/workflows/check_dependency_changes.yml

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Move this write permission from workflow level to job level.

See more on https://sonarcloud.io/project/issues?id=Adyen_adyen-android&issues=AZ9yKL9GvSpjtQlrUjV3&open=AZ9yKL9GvSpjtQlrUjV3&pullRequest=2886

jobs:
get_base_dependency_list:
Expand All @@ -28,19 +28,19 @@
needs: [ get_head_dependency_list, get_base_dependency_list ]

steps:
- uses: actions/checkout@v5
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
with:
sparse-checkout: |
scripts/check_dependency_changes.py
sparse-checkout-cone-mode: false

- name: Download base dependency list artifact
uses: actions/download-artifact@v5
uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1
with:
name: "DEPENDENCY_LIST_BASE"

- name: Download head dependency list artifact
uses: actions/download-artifact@v5
uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1
with:
name: "DEPENDENCY_LIST_HEAD"

Expand All @@ -63,15 +63,15 @@
fi

- name: Add comment on PR
uses: thollander/actions-comment-pull-request@v3
uses: thollander/actions-comment-pull-request@24bffb9b452ba05a4f3f77933840a6a841d1b32b # v3.0.1
if: steps.compare_deps.outputs.has_changes == 'true'
with:
file-path: "${{ github.workspace }}/dependency_changes.md"
comment-tag: dependency_changes
mode: recreate

- name: Delete comment from PR
uses: thollander/actions-comment-pull-request@v3
uses: thollander/actions-comment-pull-request@24bffb9b452ba05a4f3f77933840a6a841d1b32b # v3.0.1
if: steps.compare_deps.outputs.has_changes == 'false'
with:
comment-tag: dependency_changes
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/check_labels.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
allowed-labels: ${{ steps.get_allowed_labels.outputs.allowed_labels }}

steps:
- uses: actions/checkout@v5
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0

- name: Get the list of allowed pull request labels
id: get_allowed_labels
Expand All @@ -45,7 +45,7 @@ jobs:
needs: get_allowed_labels

steps:
- uses: actions/checkout@v5
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0

- name: Validate release notes
env:
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/code_analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,16 +12,16 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v5
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0

- name: Set up JDK
uses: actions/setup-java@v5
uses: actions/setup-java@1bcf9fb12cf4aa7d266a90ae39939e61372fe520 # v5.4.0
with:
distribution: 'zulu'
java-version: 17

- name: Gradle cache
uses: gradle/actions/setup-gradle@v4
uses: gradle/actions/setup-gradle@3f131e8634966bd73d06cc69884922b02e6faf92 # v6.2.0
with:
cache-read-only: true

Expand All @@ -36,16 +36,16 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v5
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0

- name: Set up JDK
uses: actions/setup-java@v5
uses: actions/setup-java@1bcf9fb12cf4aa7d266a90ae39939e61372fe520 # v5.4.0
with:
distribution: 'zulu'
java-version: 17

- name: Gradle cache
uses: gradle/actions/setup-gradle@v4
uses: gradle/actions/setup-gradle@3f131e8634966bd73d06cc69884922b02e6faf92 # v6.2.0
with:
cache-read-only: true

Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/codeql.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,16 +29,16 @@ jobs:

steps:
- name: Checkout repository
uses: actions/checkout@v5
uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0

# Initializes the CodeQL tools for scanning.
- name: Initialize CodeQL
uses: github/codeql-action/init@v3
uses: github/codeql-action/init@54f647b7e1bb85c95cddabcd46b0c578ec92bc1a # v4.36.3
with:
languages: ${{ matrix.language }}
build-mode: ${{ matrix.build-mode }}

- name: Perform CodeQL Analysis
uses: github/codeql-action/analyze@v3
uses: github/codeql-action/analyze@54f647b7e1bb85c95cddabcd46b0c578ec92bc1a # v4.36.3
with:
category: "/language:${{matrix.language}}"
4 changes: 2 additions & 2 deletions .github/workflows/create_github_release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,11 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v5
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0

# Create a Github release with release notes.
- name: Create Github release
uses: ncipollo/release-action@v1
uses: ncipollo/release-action@339a81892b84b4eeb0f6e744e4574d79d0d9b8dd # v1.21.0
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
VERSION_NAME: ${{ inputs.version-name }}
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/create_release_notes_pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v5
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0

- name: Download release notes artifact
uses: actions/download-artifact@v5
uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1
env:
VERSION_NAME: ${{ inputs.version-name }}
with:
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/finalize_release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@
type: string

permissions:
contents: write

Check warning on line 13 in .github/workflows/finalize_release.yml

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Move this write permission from workflow level to job level.

See more on https://sonarcloud.io/project/issues?id=Adyen_adyen-android&issues=AZ9yKL9TvSpjtQlrUjV4&open=AZ9yKL9TvSpjtQlrUjV4&pullRequest=2886
deployments: write

Check warning on line 14 in .github/workflows/finalize_release.yml

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Move this write permission from workflow level to job level.

See more on https://sonarcloud.io/project/issues?id=Adyen_adyen-android&issues=AZ9yKL9TvSpjtQlrUjV5&open=AZ9yKL9TvSpjtQlrUjV5&pullRequest=2886

jobs:
update_release_notes:
Expand All @@ -26,11 +26,11 @@
needs: update_release_notes

steps:
- uses: actions/checkout@v5
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0

# Publish Github release and the tag
- name: Publish Github release
uses: ncipollo/release-action@v1
uses: ncipollo/release-action@339a81892b84b4eeb0f6e744e4574d79d0d9b8dd # v1.21.0
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
VERSION_NAME: ${{ inputs.version-name }}
Expand All @@ -49,7 +49,7 @@
needs: publish_draft_release

steps:
- uses: actions/checkout@v5
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0

- name: Remove release branch
env:
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/generate_dependency_graph.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,23 +11,23 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v5
uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0

# Setup Java 17
# https://github.com/marketplace/actions/setup-java-jdk
- name: Set up JDK
uses: actions/setup-java@v5
uses: actions/setup-java@1bcf9fb12cf4aa7d266a90ae39939e61372fe520 # v5.4.0
with:
distribution: 'zulu'
java-version: 17

- name: Gradle cache
uses: gradle/actions/setup-gradle@v4
uses: gradle/actions/setup-gradle@3f131e8634966bd73d06cc69884922b02e6faf92 # v6.2.0
with:
cache-read-only: true

- name: Setup Graphviz
uses: ts-graphviz/setup-graphviz@v2
uses: ts-graphviz/setup-graphviz@b1de5da23ed0a6d14e0aeee8ed52fdd87af2363c # v2.0.2

- name: Generate Dependency Graph
run: ./gradlew dependencyGraph
Expand All @@ -40,7 +40,7 @@ jobs:
git commit -am 'Update dependency graph'

- name: Push
uses: ad-m/github-push-action@master
uses: ad-m/github-push-action@881a6320fdb16eb5318c5054f31c218aec2b324c # master
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
branch: ${{ github.ref }}
10 changes: 5 additions & 5 deletions .github/workflows/generate_release_notes.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
type: string

permissions:
contents: write

Check warning on line 11 in .github/workflows/generate_release_notes.yml

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Move this write permission from workflow level to job level.

See more on https://sonarcloud.io/project/issues?id=Adyen_adyen-android&issues=AZ9yKL63vSpjtQlrUjVz&open=AZ9yKL63vSpjtQlrUjVz&pullRequest=2886

jobs:
get_allowed_labels:
Expand All @@ -18,7 +18,7 @@
allowed-labels: ${{ steps.get_allowed_labels.outputs.allowed_labels }}

steps:
- uses: actions/checkout@v5
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0

- name: Get the list of allowed pull request labels
id: get_allowed_labels
Expand All @@ -42,13 +42,13 @@
needs: get_allowed_labels

steps:
- uses: actions/checkout@v5
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
with:
fetch-depth: 0

- uses: actions/setup-python@v6
- uses: actions/setup-python@ece7cb06caefa5fff74198d8649806c4678c61a1 # v6.3.0
with:
python-version: '3.13'
python-version: '3.14'

- name: Generate release notes
id: generate_release_notes
Expand All @@ -60,11 +60,11 @@
run: |
chmod +x scripts/generate_release_notes.py
RELEASE_NOTES_FILE_NAME="${VERSION_NAME}.md"
pip install requests toml

Check warning on line 63 in .github/workflows/generate_release_notes.yml

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Using dependencies without locking resolved versions is security-sensitive.

See more on https://sonarcloud.io/project/issues?id=Adyen_adyen-android&issues=AZ9yKL63vSpjtQlrUjVy&open=AZ9yKL63vSpjtQlrUjVy&pullRequest=2886

Check warning on line 63 in .github/workflows/generate_release_notes.yml

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Omitting "--only-binary :all:" can lead to the execution of setup scripts. Make sure it is safe here.

See more on https://sonarcloud.io/project/issues?id=Adyen_adyen-android&issues=AZ9yKL63vSpjtQlrUjVx&open=AZ9yKL63vSpjtQlrUjVx&pullRequest=2886
python scripts/generate_release_notes.py $RELEASE_NOTES_FILE_NAME

- name: Upload release notes artifact
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
env:
VERSION_NAME: ${{ inputs.version-name }}
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/generate_version_name.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
version-name: ${{ steps.generate_version_name.outputs.version_name }}

steps:
- uses: actions/checkout@v5
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
- name: Generate version name
id: generate_version_name
run: |
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/get_dependency_list.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,22 +19,22 @@ jobs:
name: Fetch dependency list

steps:
- uses: actions/checkout@v5
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
with:
ref: ${{ inputs.ref }}

- name: Setup gradle
uses: gradle/actions/setup-gradle@v4
uses: gradle/actions/setup-gradle@3f131e8634966bd73d06cc69884922b02e6faf92 # v6.2.0

- name: Fetch dependency list
env:
ARTIFACT_NAME: ${{ inputs.artifact-name }}
run: |
DEPENDENCY_LIST_FILE_NAME=$(echo "${ARTIFACT_NAME}")
./gradlew dependencyList -q --no-configuration-cache -PoutputFileName=$DEPENDENCY_LIST_FILE_NAME
./gradlew dependencyList -q --no-configuration-cache --no-parallel -PoutputFileName=$DEPENDENCY_LIST_FILE_NAME

- name: Upload dependency list artifact
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
with:
name: "${{ inputs.artifact-name }}"
path: "${{ inputs.artifact-name }}"
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/publish_docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,18 +15,18 @@ jobs:
steps:
# Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
# https://github.com/marketplace/actions/checkout
- uses: actions/checkout@v5
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0

# Setup Java 17
# https://github.com/marketplace/actions/setup-java-jdk
- name: Set up JDK
uses: actions/setup-java@v5
uses: actions/setup-java@1bcf9fb12cf4aa7d266a90ae39939e61372fe520 # v5.4.0
with:
distribution: 'zulu'
java-version: 17

- name: Gradle cache
uses: gradle/actions/setup-gradle@v4
uses: gradle/actions/setup-gradle@3f131e8634966bd73d06cc69884922b02e6faf92 # v6.2.0
with:
cache-read-only: true

Expand All @@ -35,11 +35,11 @@ jobs:

# Generate kdocs
- name: Generate Dokka HTML documentation
run: ./gradlew dokkaHtmlMultiModule
run: ./gradlew dokkaGenerate

# Deploy to GitHub Pages
- name: Deploy GitHub Pages
uses: JamesIves/github-pages-deploy-action@v4.7.3
uses: JamesIves/github-pages-deploy-action@d92aa235d04922e8f08b40ce78cc5442fcfbfa2f # v4.8.0
with:
BRANCH: gh-pages
FOLDER: build/docs/
Loading
Loading