fix(a11y): improve color contrast and add aria-labels for WCAG AA - #34
Open
rafaumeu wants to merge 1 commit into
Open
fix(a11y): improve color contrast and add aria-labels for WCAG AA#34rafaumeu wants to merge 1 commit into
rafaumeu wants to merge 1 commit into
Conversation
…pliance Replace text-gray-400 with text-gray-500 across 21 files for sufficient contrast ratio on white backgrounds (3.0:1 → 5.6:1). Add aria-label to icon-only AIJ logo links in 4 header components. Add aria-hidden to decorative SDALogoAIJ SVG elements. Resolves Adventech#22 Closes Adventech#21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two accessibility issues identified in #21 and #22.
Color Contrast (resolves #22)
text-gray-400(#9ca3af, contrast 3.0:1 on white) withtext-gray-500(#6b7280, contrast 5.6:1) across 21 filestheme-dark:text-gray-400) left unchanged - appropriate contrast on dark backgroundstheme-sepia:andhover:variants consistentlyAccessible Link Names (closes #21)
aria-label="Alive in Jesus home"to icon-only logo links in 4 AIJ header components (Beginner, Primary, Babies, Kindergarten)aria-hidden="true"to decorative SDALogoAIJ SVG elements in those same headersFiles changed
Testing