ci: enforce TLS for authenticated resource writes - #78
Draft
Jeremy1844 wants to merge 2 commits into
Draft
Conversation
This was referenced Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Both authenticated write paths explicitly set
http.sslVerifytofalse. That makes Git accept a server connection whose certificate chain cannot be verified. The workflows now set repository-localhttp.sslVerify=true, so trust failures stop the operation instead of bypassing verification.This draft addresses only
ADV-2026-0056/RC-0056. Credential lifetime and transport, dispatch validation, action provenance, and permissions remain separate roots.Evidence
js-yaml4.1.0git diff --checkpassessrc,assets,ops, package, and lock objects are unchangeddeploy-assets.ymlbut edits only the path-filter hunk; the exact combined tree composes cleanly and passes 5/5 focused cases plus YAML/diff/protected-tree/secret gatesOperational notes
There is no user-data, schema, artifact, or content migration. If a runner or proxy lacks the required CA chain, the safe response is to pause the authenticated writer and repair trust at the runner/platform boundary. Restoring
sslVerify=falseis not a safe rollback.No authenticated staging fetch/push, hosted-runner CA validation, or invalid-certificate negative test was performed. Those remain maintainer-owned pre-merge gates, and the invalid-certificate test must use an isolated staging endpoint rather than production.