Skip to content

fix(block-kit): keep highlighted Bible links clickable - #1552

Draft
Jeremy1844 wants to merge 1 commit into
Adventech:mainfrom
Jeremy1844:fix/adv-2026-0023-android-highlight-anchor-click
Draft

fix(block-kit): keep highlighted Bible links clickable#1552
Jeremy1844 wants to merge 1 commit into
Adventech:mainfrom
Jeremy1844:fix/adv-2026-0023-android-highlight-anchor-click

Conversation

@Jeremy1844

Copy link
Copy Markdown

Audit root

  • Audit ID: ADV-2026-0023 / RC-0023
  • Related issue: Can't click in highlighted Bible texts #1547
  • Base: 55405f66a8c555047dc0035747acdcaa371d59fa
  • Head: 13b6247f4d98a6a76a2faf4f8c01424f9dfd4292
  • Scope: one commit, one root, 3 files

Why

Compose BlockKit inserts a visual rounded_corner_span annotation before the preserved semantic url annotation for highlighted text. The tap path selected the first annotation at the offset and only afterward checked its tag, so the decoration shadowed highlighted Bible links and navigation was ignored.

Minimal fix

Query the semantic url tag directly through one shared AnnotatedString.urlAt(position) resolver and use it in both selectable and non-selectable Markdown rendering. No parser, persistence, schema, URI destination, content, dependency, or deployment changes are included.

Regression evidence

  • Expected RED: the focused highlighted-link regression could not compile before the semantic resolver existed.
  • PASS: focused regression, 1/1.
  • PASS: :libraries:block-kit:ui:check spotlessCheck; 20/20 BlockKit tests, zero failures/errors/skips.
  • PASS: :app:bundleRelease (1,200 Gradle tasks).
  • PASS: clean integration with the paragraph persistence reducer.
  • PASS: exact diff/ancestry checks and clean worktree.

Local environment: checked-in Gradle 9.4.0 wrapper, Temurin 21.0.11, Android SDK/API 36. Hosted CI, emulator/device, TalkBack, keyboard/D-pad, signed build, release, and deployment results are not claimed.

Overlap and compatibility

PR #1548 changes only screen timeout behavior. Drafts #1549-#1551 address separate persistence/migration/PDF roots. This PR has no file/root overlap with any of them and all merge-tree checks pass. The contrast root is intentionally separate and merges cleanly.

No data or wire migration is required. Existing URI values and callbacks remain unchanged. Reverting this commit is format-compatible but restores the click defect.

The published commit uses the account's GitHub noreply identity; its tested source tree, parent, message, and stable patch ID are unchanged from the recorded local evidence.

Keep this PR in draft until hosted Android CI and the minimum/current API, selection gesture, RTL, TalkBack, keyboard/D-pad, and release-equivalent device matrix pass. Do not merge or close #1547 from local evidence alone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't click in highlighted Bible texts

1 participant