fix(bridge): rescope verify's push box to committed, and stop over-claiming PRECHECK coverage - #4
Merged
Conversation
…aiming PRECHECK coverage
Two defects found by the 1.3.0 audit sweep but left out of it, because
neither is the "names one instance where it means a class" shape the
sweep was hunting.
1. templates/verify.md §5 shipped the box "All relevant commits pushed",
which can never be truthfully ticked: verify runs at apply step 3 and
the branch is pushed at step 6. Observed live — a real cycle left it
unchecked and wrote a prose note explaining why. Rescoped to "All code
changes committed", which is what schema.yaml's own check 5 asks for
("Confirm all code changes are committed (no unstaged files in the
worktree)"), so template and instruction now agree. A note records why
it is committed-not-pushed, so it does not get "helpfully" restored.
2. The schema description claimed "Each artifact / apply step verifies
its required skills before invoking and surfaces a clear error if any
are missing." The verify artifact's openspec-verify-change invoke has
no availability PRECHECK — deliberately, since it has a documented
manual fallback. A class claim with an instance implementation: the
inverse of the audited shape, and the description is the first thing
`openspec schemas` shows an adopter. Now scoped to Superpowers skills
and names the exception. README:439 and the touchpoint table were
already correct on this, so no doc change was needed.
VERSION 1.3.0 → 1.3.1 (prose/template corrections, no gate change).
Validated: `openspec schema validate superpowers-bridge` passes, and the
corrected description renders as intended in `openspec schemas`.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two defects found by the 1.3.0 audit sweep but left out of it, because
neither is the "names one instance where it means a class" shape the
sweep was hunting.
templates/verify.md §5 shipped the box "All relevant commits pushed",
which can never be truthfully ticked: verify runs at apply step 3 and
the branch is pushed at step 6. Observed live — a real cycle left it
unchecked and wrote a prose note explaining why. Rescoped to "All code
changes committed", which is what schema.yaml's own check 5 asks for
("Confirm all code changes are committed (no unstaged files in the
worktree)"), so template and instruction now agree. A note records why
it is committed-not-pushed, so it does not get "helpfully" restored.
The schema description claimed "Each artifact / apply step verifies
its required skills before invoking and surfaces a clear error if any
are missing." The verify artifact's openspec-verify-change invoke has
no availability PRECHECK — deliberately, since it has a documented
manual fallback. A class claim with an instance implementation: the
inverse of the audited shape, and the description is the first thing
openspec schemasshows an adopter. Now scoped to Superpowers skillsand names the exception. README:439 and the touchpoint table were
already correct on this, so no doc change was needed.
VERSION 1.3.0 → 1.3.1 (prose/template corrections, no gate change).
Validated:
openspec schema validate superpowers-bridgepasses, and thecorrected description renders as intended in
openspec schemas.Co-Authored-By: Claude Opus 5 (1M context) noreply@anthropic.com