fix: use backticks for template literals in github.ts - #819
Open
saurabhhhcodes wants to merge 1 commit into
Open
fix: use backticks for template literals in github.ts#819saurabhhhcodes wants to merge 1 commit into
saurabhhhcodes wants to merge 1 commit into
Conversation
Template literals were using single quotes instead of backticks,
causing ${GITHUB_API} and ${DEVPATH_REPO} to be treated as literal
strings instead of interpolated variables. This broke all GitHub API
calls by requesting literal URLs like '${GITHUB_API}/user' instead
of the actual API endpoint.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Template literals using single quotes instead of backticks caused
${GITHUB_API}and${DEVPATH_REPO}to render as literal strings instead of interpolating variable values. This broke all GitHub API calls.Fixes:
src/lib/github.ts:8- Changed tofor `/user`\n- `src/lib/github.ts:20` - Changed tofor/user/repos\n-src/lib/github.ts:79,88- Changed to `` for/repos/DEVPATH_REPO/stats/contributors