fix: replace innerHTML with textContent and fix NotificationDropdown spread order - #814
Open
saurabhhhcodes wants to merge 2 commits into
Open
fix: replace innerHTML with textContent and fix NotificationDropdown spread order#814saurabhhhcodes wants to merge 2 commits into
saurabhhhcodes wants to merge 2 commits into
Conversation
added 2 commits
July 19, 2026 22:45
…spread order - wiki/page.tsx: use textContent instead of innerHTML for the copy button to avoid XSS vectors, hydration mismatches, and DOM manipulation anti-patterns in React - NotificationDropdown.tsx: place id after the spread so doc.data() fields cannot override the Firestore document id
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
1. innerHTML to textContent (wiki/page.tsx)
Bug:
button.innerHTML = "Copy"andbutton.innerHTML = "Copied!"directly manipulate DOM in a React component — this causes hydration mismatches and is an XSS vector even for innocuous text.Fix: Replace innerHTML assignments with textContent, which safely sets text without parsing HTML.
2. Notification Spread Override (NotificationDropdown.tsx)
Bug:
{ id: doc.id, ...doc.data() }can silently override the Firestore documentidifdoc.data()happens to contain anidfield (e.g., a user-visible notification ID).Fix: Place
id: doc.idafter the spread sodoc.data()fields cannot clobber the canonical document identifier.