refactor: abstract community reports localStorage access - #688
Merged
Aditya8369 merged 1 commit intoAug 12, 2026
Merged
Conversation
|
@Suprita736 is attempting to deploy a commit to the Aditya Mahajan's projects Team on Vercel. A member of the Team first needs to authorize it. |
Thank You for Your Contribution! 🎉Hi @Suprita736, Thank you for opening this Pull Request and contributing to our project. We truly appreciate your efforts.
The maintainer @Aditya8369 will review your PR shortly! Happy Contributing! 🚀 |
|
🎉 Your PR just got merged, @Suprita736 — thank you for contributing to Pollution Control Hub! Your work is now part of the project. Here's what to do next:
We really appreciate you taking the time. See you in the next PR! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Extracts the LocationMap component's direct localStorage access for community reports into a new
useCommunityReportshook, so the component no longer owns that side effect directly and the hook's return value can be mocked in tests.Related Issue
Closes #626
Type of Change
Changes Made
src/hooks/useCommunityReports.js, encapsulating the localStorage read,COMMUNITY_REPORT_SUBMITTEDevent subscription, and cross-tabstorageevent sync previously inline inLocationMap.jsx.LocationMap.jsxnow consumesuseCommunityReports()instead of managing its own state/effect for community reports; storage key constant, reader function, and the associateduseEffectwere removed from the component.Testing
Checklist
Additional Notes
Symptom reports still read localStorage inline in
LocationMap.jsx— left untouched since #626 scopes only community reports. Could be a good follow-up issue (useSymptomReports) if desired.