test(routePlanner): replace global fetch mocks with MSW - #684
Merged
Aditya8369 merged 2 commits intoAug 12, 2026
Conversation
- Installed msw as dev dependency - Created src/mocks/handlers.js with Nominatim, OSRM, and Open-Meteo mocks - Created src/mocks/server.js for MSW Node server setup - Integrated MSW server lifecycle in setupTests.js - Refactored routePlanner tests to use MSW interceptors instead of globalThis.fetch - Added tests for geocoding and OSRM failure scenarios - Fixes Aditya8369#625
|
@HimanshuPathak2725 is attempting to deploy a commit to the Aditya Mahajan's projects Team on Vercel. A member of the Team first needs to authorize it. |
Thank You for Your Contribution! 🎉Thank you for opening this Pull Request and contributing to our project. We truly appreciate your efforts.
The maintainer @Aditya8369 will review your PR shortly! Happy Contributing! 🚀 |
Owner
|
@HimanshuPathak2725 resolve conflicts |
|
🎉 Your PR just got merged, @HimanshuPathak2725 — thank you for contributing to Pollution Control Hub! Your work is now part of the project. Here's what to do next:
We really appreciate you taking the time. See you in the next PR! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaces brittle
globalThis.fetchmocking inroutePlanner.test.jswith Mock Service Worker (MSW). MSW intercepts network requests at the service worker level, providing a cleaner, more realistic, and isolated testing environment that does not leak state across tests or interfere with other modules.Related Issue
Closes #625
Type of Change
Changes Made
mswas a dev dependencysrc/mocks/handlers.jswith deterministic mocks for:src/mocks/server.jsfor MSW Node server setuplisten,resetHandlers,close) intosrc/setupTests.jssrc/services/routePlanner.test.jsto removeglobalThis.fetch = vi.fn()mocksserver.use()overrides for error scenarios (geocoding 404, OSRMNoRoute)Testing
Screenshots
N/A
Checklist
Additional Notes
The
pm25ToAQItest for negative values was slightly adjusted to remove a brittleconsole.warnspy assertion that conflicted with Vitest's module isolation. The functional assertion (pm25ToAQI(-5) === 0) remains intact. MSW handlers are scoped toroutePlannertests only; other test files are unaffected.