chore: drop an unused destructured binding in RouteResults.test.jsx - #677
Open
MOHITKOURAV01 wants to merge 1 commit into
Open
chore: drop an unused destructured binding in RouteResults.test.jsx#677MOHITKOURAV01 wants to merge 1 commit into
MOHITKOURAV01 wants to merge 1 commit into
Conversation
Follow-up to Aditya8369#672. The mode-fallback case built its fixture with a rest destructure whose `mode` binding was never used, which ESLint flags as no-unused-vars. A shallow copy with the key deleted says the same thing and leaves nothing dangling. Test behaviour is unchanged — 10 passing either way.
Thank You for Your Contribution! 🎉Hi @MOHITKOURAV01, Thank you for opening this Pull Request and contributing to our project. We truly appreciate your efforts.
The maintainer @Aditya8369 will review your PR shortly! Happy Contributing! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small follow-up to #672, which merged before I pushed this.
The mode-fallback case built its fixture with a rest destructure:
modeis never used — the point is to produce a route object without it — so ESLint flags it asno-unused-vars. A shallow copy with the key deleted expresses the same intent and leaves nothing dangling.No behaviour change:
RouteResults.test.jsxis 10 passing before and after.