Only Generate results value builder and its related changes - #326
Open
Jatin1628 wants to merge 1 commit into
Open
Only Generate results value builder and its related changes#326Jatin1628 wants to merge 1 commit into
Jatin1628 wants to merge 1 commit into
Conversation
|
|
||
| KEY_LC_COMBINATIONS = "loading.load_combination.combinations" | ||
| KEY_LC_TAB = "loading.load_combination.tab" | ||
| KEY_LC_REPORT = "loading.load_combination.report" |
Collaborator
There was a problem hiding this comment.
name will be changed
| """Return design_results[KEY_SD_ULS_PER_GIRDER], or {} if unavailable.""" | ||
| if bridge is None: | ||
| return {} | ||
| def _display_girders(output_dict, keys) -> list: |
Collaborator
There was a problem hiding this comment.
check why this function is needed here since output will have the correct no. of girders without edge beams
| min_sl = EMPTY | ||
| cd = (dr.get("capacity_details") or {}) | ||
| clause = cd.get("stud_spacing", {}).get("clause") or "IRC 22 Cl. 606.4.1" | ||
| clause = _val(cd.get("stud_spacing", {}).get("clause")) |
Collaborator
There was a problem hiding this comment.
check if this should be here or we decided to remove
|
|
||
| def _get_cache(output_dict): | ||
| """Return the load-effects envelope from output_dict, or None if absent.""" | ||
| cache = (output_dict or {}).get("load_effects_cache") |
Collaborator
There was a problem hiding this comment.
where is load effects cache being called from?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generate results' resolvers always read from Output Dict