All values come from output dict - #314
Open
Jatin1628 wants to merge 1 commit into
Open
Conversation
Jatin1628
force-pushed
the
Gen_res_refactor
branch
from
July 27, 2026 09:37
807e7ed to
43bc659
Compare
|
|
||
| return report_text, engine, design_results | ||
|
|
||
| def store_permanent_load_breakdown(input_dict: dict, output_dict: dict) -> None: |
Collaborator
There was a problem hiding this comment.
why all this in designer?
| return entries | ||
|
|
||
| display = f"{combo_name} : {expr}" | ||
| @staticmethod |
Jatin1628
force-pushed
the
Gen_res_refactor
branch
from
July 29, 2026 12:31
43bc659 to
5886116
Compare
Jatin1628
force-pushed
the
Gen_res_refactor
branch
from
July 29, 2026 15:06
5886116 to
7c91139
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added some keys.
Added some values that were not already being written into the inputs dict and also output dict.
All resolvers in generate results now read only from output dict with no fallbacks.