fix: transverse Member Design > Cross Bracing - CAD preview not updating when switching girders - #296
Open
garvit000 wants to merge 14 commits into
Open
fix: transverse Member Design > Cross Bracing - CAD preview not updating when switching girders#296garvit000 wants to merge 14 commits into
garvit000 wants to merge 14 commits into
Conversation
Collaborator
the label shows "M1" when there are 9 cross bracings. It should show M1 to M9.
|
Collaborator
|
@garvit000 please look into crossbracingforces.py file, and the input and output dictionary for cross bracing and end diaphragm. Whatever I am entering for custom design is not being reflected in the transverse member design dialog box. Can you fix that also? |
|
I tested this PR and noticed the following:
|
|
check Type of Bracing, section designation also |
…ing when switching girders
…r Design
Cross-bracing UI selections were read from stale flat keys, so K-Bracing,
chord flags, spacing and custom sections were ignored and defaults shown.
- read cross-bracing config (type, chords, spacing) from the per-member
input keys instead of dead flat keys; wire custom-mode sections into the
Osdag design runs
- read chord enable flags and section designations per girder pair (G1-G2
may differ from G2-G3) and per chord (top vs bottom can differ)
- populate the bottom-chord output properties from its own section
- interpret Yes/No checkbox values via as_bool (bool("No") was truthy, so
unchecked chords displayed as checked)
- coerce Osdag capacity/efficiency/slenderness to float to stop a
format crash when they return as strings
| deck_t_mm = float(inp[KEY_TS_DECK_THICKNESS]) | ||
| wc_t_m = float(inp[KEY_WC_THICKNESS]) / 1000.0 # wearing course thickness (m) | ||
| cb_spacing_m = float(inp.get(KEY_MP_CB_SPACING) or 3.0) # longitudinal cross-bracing spacing (m) | ||
| from osdagbridge.core.bridge_types.plate_girder.plategirderbridge import resolve_cb_value |
Collaborator
There was a problem hiding this comment.
remove resolve cb value function from here if not needed
Collaborator
Author
There was a problem hiding this comment.
without that it fails to get correct spacing for each girder pair
| # falls back to the representative (first) girder — see resolve_girder_value(). | ||
| from osdagbridge.core.bridge_types.plate_girder.plategirderbridge import ( | ||
| resolve_girder_value as _gv, | ||
| resolve_cb_value as _cbv, |
Collaborator
There was a problem hiding this comment.
remove resolve cb value function from here if not needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #200 and #201