Repository navigation
Simagic: keep the rotation until unplugged, never offer to save it - #23
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #22 (left open until it is confirmed on the hardware).
What was wrong
On Simagic bases the rotation was declared persistent (every
Settingin the plugin kit was), but the plugin refuses to save it: applied at plug-in, it could catch the wheel outside the new rotation and the base would lose its force feedback. So the GUI marked the rotation as "Changed: save it to keep it", and pressing Save failed with-32005("The rotation is not saved for the next plug-in…"). Presets hit the same contradiction and reported "not saved".What changed
simrig-plugin-kit:Settinggets apersistentflag (on by default). When off, the parameter is reported as lasting until unplugged.persistent: false. The special case inBase::saveis gone, since the SDK dispatch already refuses saving a volatile parameter.docs/architecture.md: one sentence on the rotation lasting until unplugged.For the reviewer
ffb_strengthstays persistent, and a preset withrotation = 720applies without trying to save; a kit unit test covers the flag.cargo fmt --check,clippy -D warningsandcargo test --workspacepass. Not tested on real hardware.