Repository navigation
Halve redraws while the wheel moves, draw the formula rim's text in software - #19
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes found while measuring the GUI after #17.
Press badge redrawing twice per live frame. The badge on the steering wheel card faded with an animation bound to the whole
device: every live frame started it again, which drew one more frame, so a moving wheel redrew at twice the live rate (120 fps). It now follows a property set only when the badge shows or hides. With the simulated rig moving: 60 fps, GPU from 14.5% to 7%.Missing text on CPU-drawn layers. With the software renderer (and in
--screenshot), the rotated wheel is drawn byraster.rswith resvg, whose font database was empty: the gear digit on the formula rim's display was left out. The layers now load the bundled Martian Mono, and resvg'stextfeature is asked for explicitly instead of coming from Slint's.