feat: support line/block comments and the modulo operator - #7
Merged
Conversation
- Lexer skips // line comments and /* */ block comments, with an error for unterminated block comments - New % token, BinaryOp::Modulo at multiplicative precedence, lowered to LLVM srem - Unit tests for comment skipping and % tokenization; e2e tests for modulo evaluation, precedence, and comment handling Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This was referenced Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Adds two small quality-of-life features on top of the newly merged function support:
//line comments and/* ... */block comments, and reports an error for unterminated block comments. (Resolves the lexer TODO.)%token,BinaryOp::Moduloparsed at multiplicative precedence, lowered to LLVMsrem.Tests: 4 new lexer unit tests (line/block comments, unterminated-comment error,
%tokenization) and 3 new e2e tests (modulo evaluation, precedence grouping, comments in a full program). Full suite: 27 unit + 27 e2e passing, clippy/fmt clean.cc @hand-burger — follows on from your function-support stack (#1-#6), in case you want to build compound assignment (
+=,%=) on top of this.🤖 Generated with Claude Code