Tigers - Melley Gebretatios and QP#22
Open
mell2022 wants to merge 23 commits into
Open
Conversation
…ass, wave 5 all pass, add assert back to wave 1- all pass
…unit tests and integr test1-3 passes
…_item, implemented get_best_by_category, no tests passing
CheezItMan
reviewed
Nov 20, 2022
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Very nicely done Melly & QP,
Very clean code and it all seems to work. Well done.
| if not list_of_items: | ||
| return None | ||
| else: | ||
| best_item = max(list_of_items, key = lambda item: item.condition) |
Author
|
Aww! Thank you so much Chris! Shoutout to my amazing partner!!
…On Sun, Nov 20, 2022 at 5:52 PM Chris M ***@***.***> wrote:
***@***.**** commented on this pull request.
Very nicely done Melly & QP,
Very clean code and it all seems to work. Well done.
------------------------------
In swap_meet/vendor.py
<#22 (comment)>:
> +
+ self.inventory.remove(my_first_item)
+ self.inventory.append(their_first_item)
+
+ vendor_friend.inventory.remove(their_first_item)
+ vendor_friend.inventory.append(my_first_item)
+
+ return True
+
+# WAVE 6
+ def get_best_by_category(self, category):
+ list_of_items = self.get_by_category(category)
+ if not list_of_items:
+ return None
+ else:
+ best_item = max(list_of_items, key = lambda item: item.condition)
Nice use of the lambda here!
—
Reply to this email directly, view it on GitHub
<#22 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AVOEQTTPUDX76RENNSLUF3DWJKTSJANCNFSM6AAAAAAQ6W2XIU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.