AAE-50049 Configure commit signing for jx-updatebot propagation in activiti-cloud-full-chart and activiti-cloud-common-chart - #413
Merged
mkrbr merged 2 commits intoAug 13, 2026
Conversation
…es for Git credentials Refactored the GitHub Actions workflow in `main.yml` to replace hardcoded secrets with environment variables for Git username and email. Added support for GPG signing with private key and fingerprint. This enhances security and maintainability of the workflow.
There was a problem hiding this comment.
Pull request overview
This PR updates the GitHub Actions propagation workflow to enable signed commits when jx-updatebot-pr opens/updates PRs, aligning the automation identity with centrally managed GitHub Actions variables.
Changes:
- Switches updatebot git identity inputs from
secrets.BOT_GITHUB_USERNAME/ noreply email tovars.HXPS_GIT_USERNAMEandvars.HXPS_GIT_EMAIL. - Adds GPG signing inputs (
gpg-private-key,gpg-private-key-fingerprint) to support commit signing for updatebot-created commits. - Removes the explicit
GH_TOKENenv injection for thejx-updatebot-prstep (token remains provided viagit-tokeninput).
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
mkrbr
marked this pull request as ready for review
August 11, 2026 10:01
andrphilippi
approved these changes
Aug 13, 2026
…gning-jx-updatebot
mkrbr
deleted the
improvement/AAE-50049-configure-commit-signing-jx-updatebot
branch
August 13, 2026 16:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Description
Does this PR introduce a breaking change?