Added Docker pipeline generate job, alternative Docker registry support and no-cache to docker build - #5
Open
RobertNorthard wants to merge 5 commits into
Open
Conversation
Signed-off-by: Robert Northard <robertnorthard@googlemail.com>
RobertNorthard
force-pushed
the
master
branch
from
February 6, 2017 00:02
5856d8b to
7a9d182
Compare
|
Tested this, looks really good. I'll demo it tomorrow at Config Management camp! Minor question: why do you need the git url and the git repo name? Can the repo name not always be extracted from the other? |
Author
|
@kramos thanks. I'm not to keen on the Git repo name either. It is used by the Gerrit trigger. I was going to factor it out when the SCM pluggable library had been integrated with the core as the library would deal with this. |
|
It would be nice if the seed job got auto run with the defaults. |
Signed-off-by: Robert Northard <robertnorthard@googlemail.com>
RobertNorthard
force-pushed
the
master
branch
from
February 10, 2017 19:38
4e3a8ae to
8935094
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is dependent on PR#3 being merged.
** The trigger part of the Get_Dockerfile job only works with Gerrit but the pipeline can test Dockerfiles in arbitrary Git repositories e.g. GitHub. This can be corrected when the ADOP SCM pluggable library is added to the core.
** Defaults to the public docker registry.
Next steps;