Add Fisherbrand 14.8 mL vial and corresponding vial plate - #11
Open
Steafy7 wants to merge 2 commits into
Open
Conversation
Author
|
The testing environment used to test these assets are located here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the self-modelled Fisherbrand 03-339-21F 14.8 mL vial asset and its corresponding vial plate.
This PR now also includes the commit adding the corresponding vial plate asset.
Changes
BodyCylinderandCapCylindercollision definitions.Tests performed
-0.087 mm, vial tilt was0.034°, and post-settle drift was0.0011 mm.6.07 Nand6.25 N.35.352 mmagainst a35.35 mmwell-floor depth, with0.139 mmlateral error.0.391 mm.2.754 N.1.974 mmand pre-release cap-to-place residual was0.559 mm.hole_middle_centerwith0.139 mmlateral error and35.352 mminsertion.Review requested
Please review the vial and vial-plate collider dimensions, collider placement, and how the vials sit within the plate wells.
Please also review the vial glass material. The visual material was changed from OmniGlass to OmniPBR, but the glass is still not rendering correctly in RTX.