chore: make soft-deleted an optional boolean#1344
Merged
rogernelson merged 1 commit intoJul 10, 2026
Merged
Conversation
Signed-off-by: Roger Nelson <roger.nelson@autodesk.com>
rogernelson
requested review from
bernie-laberge,
cedrik-fuoco-adsk and
eloisebrosseau
as code owners
rogernelson
changed the title
rogernelson
changed the title
rogernelson
merged commit 7bd4f0c
into
AcademySoftwareFoundation:main
17 of 18 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make soft_delete a strict boolean
Summarize your change.
This is a followup to my last change. There's no reason to make soft_deleted null. This makes it an optional boolean instead.
Describe the reason for the change.
Just a cleaner approach.
Describe what you have tested and on which operating system.
Mac OS 26.5.1