fix(core): map content-less response schema to Unit, not JsonElement#79
Open
halotukozak wants to merge 1 commit into
Open
fix(core): map content-less response schema to Unit, not JsonElement#79halotukozak wants to merge 1 commit into
halotukozak wants to merge 1 commit into
Conversation
A response whose schema carries no structure (e.g. `{}` or
`{ "nullable": true }`) means "no body". It was resolved to TypeRef.Unknown
and surfaced as a `JsonElement` success type. Now such a response schema
parses to `null`, routing it through the existing no-content path so the
client method returns `HttpResult<E, Unit>`.
Responses with a real schema ($ref, type, properties, items, combinators,
enum, or additionalProperties) are unaffected.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A response whose schema carries no structure — e.g.
{}or{ "nullable": true }— means "no body". It was resolved toTypeRef.Unknownand surfaced in the client as an untypedJsonElementsuccess type instead ofUnit.Fix
Such a response schema now parses to a
nullschema, routing it through the existing no-content code path inClientGenerator.resolveReturnType, which already falls back toUNIT. No runtime change is needed — theUnitpath already existed for responses declared withoutcontent.Responses with a real schema (
$ref,type, properties, items, combinators, enum, oradditionalProperties) are unaffected.Tests
New
SpecParserEmptyResponseTest+ fixture: an empty-content response schema parses tonull, while a sibling response with a$refschema stays typed.:core:testandktlintCheckare green.