16 fix config file behavior by yonatank93 · Pull Request #19 · AUTODIAL/AutoREC

yonatank93 · 2026-06-09T13:15:39Z

Summary

Fix the behavior of the factory (both reading from a YAML file and instantiating classes from a dictionary)

For both cases, the keys and values now are treated as keywords to instantiate the environment and agent classes. We no longer assign any default values from default configurations. Thus, the behavior for instantiating classes manually or using factory should be the same.
Default configurations are moved for better organization of the code. Other parts of the code are also modified to reflect the change.

Related issue

Link the issue that this pull request addresses.

[Bug]: Make dataset_path a required key in the configuration file #16

Type of change

Please check all that apply:

Motivation and context

We want the same behavior whether we instantiate the classes manually or using factory for consistency.

Additional dependencies introduced, if any

Not applied

TODO, if any

Not applied

Checklist

Before this pull request is merged, please check the following:

Additional comments

Not applied

…ult values In this version, the keys and values in the configuration file are treated as keyword arguments to instantiate classes. This makes the behavior of running with configuration file/factory the same as if we instantiate the classes manually. For the environment class, the dataset argument is replaced with dataset_path, so that one can pass in file without needing to load the file first. Special treatment is for the configurations inside AutoREC/default_configs, where the dataset_path there is treated as path relative to the configuration file instead of to the current directory. This is because those default configurations are used for example/testing.

…nt treatment of dataset_path

…efault_configs I also created a new default configs for the docker run demo. Instead on adding more function in factory to also handle this case, I think it is just easier to just have an additional config file. It is not big anyway.

… run with minimum argument

Copilot

Pull request overview

This PR updates the configuration/factory workflow so YAML/dict configs are treated purely as constructor keyword arguments (no merging with packaged defaults), and makes dataset_path required to align factory behavior with manual instantiation.

Changes:

Remove default-config fallback/merging behavior; require dataset_path and load datasets explicitly in the factory.
Add special-case path handling so example/default_configs/* resolve dataset_path relative to the config file (and /app/default_configs inside Docker).
Reorganize/move example configs and update docs + Docker build inputs accordingly.

Reviewed changes

Copilot reviewed 13 out of 14 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
`src/autorec/factory.py`	Removes default merging, requires `dataset_path`, adds `_config_reader` for example-config path resolution.
`src/autorec/cli.py`	Switches config loading to `_config_reader` for the new example-config path behavior.
`README.md`	Updates configuration documentation and example command paths to `example/default_configs`.
`Dockerfile`	Copies `example/default_configs` into the container at `/app/default_configs`.
`pyproject.toml`	Removes packaging of `src/autorec/default_configs/*.yaml`.
`example/main_factory.py`	Adds CLI args and adjusts output-dir handling to use `agent.save_dir`.
`example/hyperparameter_tuning/main_factory.py`	Updates default config path.
`example/default_configs/*.yaml`	Updates dataset paths and moves agent config into examples.
`src/autorec/default_configs/agent_config.yaml`	Deleted (defaults no longer loaded/packaged).
`default_configs/environment_config.yaml`	Deleted (example configs relocated).

Comments suppressed due to low confidence (1)

src/autorec/factory.py:101

When args is a dict, this function assigns config = args and then mutates nested structures (e.g., agent_config) by inserting environments. This leaks side effects to callers (including the CLI) and makes it harder to reuse the config dict after calling the builder.

    if isinstance(args, (str, Path)):
        config = _config_reader(args)
    elif isinstance(args, dict):
        config = args
    else:
        raise TypeError("The 'args' parameter must be a str, Path, or dict.")

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Update the error message Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 13 out of 14 changed files in this pull request and generated 4 comments.

…oREC into 16_fix_config_file_behavior

Copilot suggestion for potential bug related to setting the save_dir in the agent configuration yaml file. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 13 out of 14 changed files in this pull request and generated 2 comments.

Update printed message. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 13 out of 14 changed files in this pull request and generated 2 comments.

Since there are already some data included, like pretrained model, dataset, etc., I think doing this reorganization makes it more consistent structure wise with the others.

yonatank93 · 2026-06-09T14:18:38Z

@ajaberi1 I think this is ready for you review. After this is merged, then I will work on unit tests.

Copilot

Pull request overview

Copilot reviewed 13 out of 16 changed files in this pull request and generated 2 comments.

yonatank93 added 8 commits June 8, 2026 15:55

These default configs are not needed anymore.

a752570

Move default_configs to example/default_configs

7ba9d0c

Modify CLI so that it uses the newer _config_reader to handle differe…

0cb0be9

…nt treatment of dataset_path

Make main_factory.py accept command line argument to be more versatile.

fb66e55

Update the default config so that hyperparameter tuning runner can be…

2079e3a

… run with minimum argument

Update README with all these changes with default_configs

4dafa2c

Copilot AI review requested due to automatic review settings June 9, 2026 13:15

Copilot started reviewing on behalf of yonatank93 June 9, 2026 13:15 View session

yonatank93 requested review from ajaberi1 and removed request for Copilot June 9, 2026 13:15

yonatank93 added the bug Something isn't working label Jun 9, 2026

yonatank93 requested a review from Copilot June 9, 2026 13:16

Copilot started reviewing on behalf of yonatank93 June 9, 2026 13:16 View session

Copilot AI reviewed Jun 9, 2026

View reviewed changes

Comment thread src/autorec/factory.py

Comment thread src/autorec/factory.py

Comment thread example/main_factory.py Outdated

Comment thread example/hyperparameter_tuning/main_factory.py

Comment thread example/main_factory.py

Comment thread src/autorec/cli.py Outdated

Potential fix for pull request finding

73d64f9

Update the error message Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings June 9, 2026 13:31

Copilot started reviewing on behalf of yonatank93 June 9, 2026 13:31 View session

Unhide _config_reader function by removing the leading "_"

815bb32

Copilot AI reviewed Jun 9, 2026

View reviewed changes

Comment thread src/autorec/factory.py

Comment thread src/autorec/factory.py

Comment thread example/main_factory.py Outdated

Comment thread README.md Outdated

yonatank93 and others added 3 commits June 9, 2026 09:36

Use the new config_reader and print the config

b75bb0b

Merge branch '16_fix_config_file_behavior' of github.com:AUTODIAL/Aut…

7fa5604

…oREC into 16_fix_config_file_behavior

Potential fix for pull request finding

6261d1d

Copilot suggestion for potential bug related to setting the save_dir in the agent configuration yaml file. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings June 9, 2026 13:43

Copilot started reviewing on behalf of yonatank93 June 9, 2026 13:43 View session

Use a copy of args dictionary to avoid overwriting the original variable

18a4df4

Copilot AI reviewed Jun 9, 2026

View reviewed changes

Comment thread src/autorec/cli.py Outdated

Comment thread src/autorec/factory.py

Potential fix for pull request finding

f0ea8a5

Update printed message. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings June 9, 2026 13:48

Copilot started reviewing on behalf of yonatank93 June 9, 2026 13:48 View session

Copilot AI reviewed Jun 9, 2026

View reviewed changes

Comment thread src/autorec/cli.py Outdated

Comment thread src/autorec/factory.py

Reorganization: Move example/default_configs to configs_yaml/examples

8f05557

Since there are already some data included, like pretrained model, dataset, etc., I think doing this reorganization makes it more consistent structure wise with the others.

yonatank93 mentioned this pull request Jun 10, 2026

WIP: Add lightweight unit tests #20

Open

29 tasks

(Copilot suggestion) Handle non-dict YAML content in config files

e701ae8

Copilot AI review requested due to automatic review settings June 10, 2026 15:54

Copilot started reviewing on behalf of yonatank93 June 10, 2026 15:54 View session

Copilot AI reviewed Jun 10, 2026

View reviewed changes

Comment thread src/autorec/factory.py

Comment thread src/autorec/cli.py

Conversation

yonatank93 commented Jun 9, 2026

Summary

Related issue

Type of change

Motivation and context

Additional dependencies introduced, if any

TODO, if any

Checklist

Additional comments

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

yonatank93 commented Jun 9, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants