Add GET preprocess trace for electronics artifacts. #279
Open
danielaramirez415 wants to merge 6 commits into
Open
Add GET preprocess trace for electronics artifacts. #279danielaramirez415 wants to merge 6 commits into
danielaramirez415 wants to merge 6 commits into
Conversation
Merge local-dev with main branch
Added correction function to PadMap, pad number matches to experiment.
Author
|
Additionally, this includes the option to check the PADMAPID matches with the h5file used. In other words, it solves the misalignment PadID vs. position in X,Y. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally
preprocess_traces()didn't account for some artifacts of the GET electronics, such as phase offset and memory error. With the new implementation, it is given to the user to decide which preprocess method they prefer:v0 or default : uses the original method
v1 : preprocess those traces with memory error or phase offset.
Note: Either version haven't solve the bitflip effect (work in progress).
Additionally, the new request gates out pulses outside the detector region (0,1000). Previously, these were only clipped for those analysis which used the Garfield correction.