Repository navigation
fix(geocode): expand feature type mappings and tolerate whitespace in viewbox bounds - #1
Merged
Conversation
…unds, and add tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This pull request improves Nominatim geocoding parsing in
src/nominatimGeocode.jsby expanding OpenStreetMap feature type classifications, tolerating delimited whitespace in bounding box viewport coordinates, and adding automated unit tests.Key Changes
Delimited Whitespace Tolerance (
src/nominatimGeocode.js):nominatimViewboxFromBoundsnow tolerates surrounding and interior whitespace around,and|coordinate delimiters, allowing robust handling of user-formatted bounds queries (e.g.30.1 , -97.95 | 30.52 , -97.55).Expanded Feature Type Classifications:
borough,subdivision,hotel,motel,museum,hospital,harbour,bay,river,lake,sea,ocean,volcano.railway(['transit_station']) andboundary(['political']).Automated Unit Tests (
src/nominatimGeocode.test.mjs):