Move type-resolution family out-of-line into MLIRGenTypes.cpp (review doc 1)#218
Merged
Merged
Conversation
… doc 1) Second slice of the TU split: the contiguous type-resolution family (getType ... getNullType, 134 methods, ~3,400 lines) moves from inline bodies in MLIRGenImpl.h to out-of-line definitions in MLIRGenTypes.cpp. The lone template member (getIndexedAccessTypeForArray<T>) stays inline in the header. Default arguments remain on declarations only. Verified: MLIRGenTests 12/12, full ctest 681/681 (JIT + AOT). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This was referenced Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second mechanical slice of the §1 TU split from docs/MLIRGen-refactoring-review.md (follows #217).
What
MLIRGenTypes.cpp(new): the contiguous type-resolution family —getTypethroughgetNullType(134 methods, ~3,400 lines: type references, generic zipping/constraints, embedded/utility types, conditional/mapped/template-literal types, tuple/union/intersection construction) — defined out-of-line.MLIRGenImpl.hshrinks from 25,202 to 22,096 lines; the moved methods keep their declarations (default arguments stay on declarations only).getIndexedAccessTypeForArray<T>, stays inline in the header (template definitions must be visible to all users).Same mechanical recipe as #217: signature/body split at the method level, bodies byte-identical,
MLIRGenImpl::qualification added.Verification
MLIRGenTests12/12.🤖 Generated with Claude Code