Make class vtable slot resolution O(1), deterministic, and kind-safe#200
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactors
ClassInfo::getVirtualTable(MLIRGenStore.h), which resolved every method override with a linearstd::find_ifover the accumulated vtable — O(methods × slots), copying each entry by value per comparison — sorted methods with unstablestd::sort, and matched method names against interface slots through the sharedmethodInfo.namefield.llvm::StringMapname→slot indices are carried through the base-class recursion; no more linear scans or per-comparison struct copies.find_ifsearched both kinds throughmethodInfo.name).std::sort→std::stable_sortonorderWeight. VTable slot order is ABI for separately compiled modules (.instanceOfmust be slot 0, DLL/consumer builds must agree), so members with equal weight — e.g. compiler-generated ones — must keep declaration order rather than an implementation-defined one.Behavior is unchanged for all non-pathological inputs; the public
getVirtualTable(vtable)signature is preserved (the map-carrying overload is used by the recursion).Test plan
00class_virtual_call,00class_virtual_table,00class_abstract,00interface) additionally run directly under-O3JIT.🤖 Generated with Claude Code