fix(backend): give the implementer the full issue body, not just the title#9
Merged
Merged
Conversation
…title assemble_backend_prompt built the "## Request" section as `intent or request`. The planner sets `intent` to the issue's truncated first line (often just the title), so the `or` short-circuited and the full request body — action items, constraints, acceptance — never reached the backend. The loop was effectively implementing against the issue title alone. task_spec_from_state already carries the full body in TaskSpec.request; prefer it over the one-line intent (fall back to intent, then a placeholder). Surfaced dogfooding the VPS launch-proof issue (hyrule-cloud#28): the loop produced a title-only plan because it never saw the detailed spec. Note: the planner's formal acceptance_criteria remain a generic template (graded by role judgment + human PR review); deriving criteria from the issue body is a separate, larger enhancement. Validation: ruff clean, mypy --strict clean, 176 passed (+1), evals 15/15. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Dogfooding the first loop code task (hyrule-cloud#28, VPS launch-proof) surfaced a substrate bug: the loop implements against the issue title only, not the body.
Root cause
assemble_backend_promptset the prompt's## Requestto:The planner sets
intentto the issue's first line truncated to 300 chars (nodes.py:317-320) — usually the title — so theorshort-circuited and the full body (task_spec.request, populated fromfeature_requestatbackend.py:819) was never included. The model never saw the action items, constraints (no generic payment engine), or acceptance.Fix
Prefer the full
requestbody over the truncatedintentin the prompt (fall back tointent, then placeholder). One line + a regression test asserting body content (action items + constraints) reaches the prompt whenintentis just a title.Out of scope (noted)
The planner's formal
acceptance_criteriaare still a generic 3-item template (nodes.py:336-339), graded by role judgment + human PR review. Deriving criteria from the issue body is a separate, larger enhancement — the dominant bug was the body never reaching the implementer at all.Validation
uvx ruff check src tests— cleanuv run --group dev mypy --strict src— cleanuv run --group dev pytest -q— 176 passed (+1)evals run --strict— 15/15Next
Merge → bump the loop pin on
loop→ re-run #28; the loop will then implement against the real spec.