feat: private eval suite — AS215932 domain judgment as token capital#7
Merged
Conversation
Add an offline, deterministic eval suite that captures AS215932/Hyrule domain judgment so it survives provider/model swaps and gates CI. - evals/cases/<family>/*.json: 15 cases across 5 families (domain-policy, promotion-safety, noc-evidence, vps-launch-proof, network-change), 3 each. - evals/schema.json: case schema. - src/hyrule_engineering_loop/evals.py: pydantic case models, a per-family deterministic rule engine (decision + rationale), loader (dedupe + schema guard), runner, and JSON summary. - CLI: `hyrule-engineering-loop evals run [--strict] [--json]`. - CI: new `evals` job runs the suite (no model, no network); failures block. - docs/engineering-loop/private-evals.md. Trace harvesting already exists (trace.py + the daemon report carry issue/outcome/cost_usd/pr_url/journal_path); the only trace gap is cost, tracked in #6 (PiBackend text mode vs JSON-expecting parser). Validation: ruff clean, mypy --strict clean, 172 pytest passed, `evals run --strict` 15/15. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Phase B of the agentic-ISP plan: build the private, offline token-capital baseline so AS215932 domain judgment is captured as code that survives provider/model swaps and gates CI. (Phase A landed the live loop; tracker network-operations#225.)
What's here
evals/cases/<family>/*.json— 15 cases across 5 families (3 each):domain-policy—servify.network(infra)/hyrule.host(product)/as215932.net(AS-routing) identities not conflated or repurposedpromotion-safety— pins viapromote-apps+apply.yml; no manual pin edits / auto-merge / auto prod applynoc-evidence— remediation needs evidence + rollback guard + approval; no real mutation in the no-op phasevps-launch-proof— stay in the narrow contract; no generic payment-intent enginenetwork-change— FRR/firewall/BGP need emulated-lab verification + human reviewevals/schema.json— case schema.src/hyrule_engineering_loop/evals.py— pydantic case models, a deterministic per-family rule engine producing(decision, rationale), a loader (dedupe + schema-version guard), runner, and JSON summary. No model, no network.hyrule-engineering-loop evals run [--strict] [--json](exit 1 on failure under--strict).evalsjob; failures block the PR.The rules are the baseline "company veteran"; the loop's LLM judgment can later be graded against the same corpus, but the deterministic rules keep CI model-free.
Trace / cost note
Trace harvesting already exists (
trace.pywritesloop_trace.json; the daemon report carriesissue/outcome/cost_usd/pr_url/journal_path). The one gap is cost —cost_usdreads 0 becausePiBackendruns text mode while the parser expects JSON; tracked in #6, not in scope here.Validation
uvx ruff check src tests— cleanuv run --group dev mypy --strict src— cleanuv run --group dev pytest -q— 172 passed (+11)uv run --group dev hyrule-engineering-loop evals run --strict— 15/15