feat(daemon): per-run budget override flags (iterations + wall clock)#10
Merged
Conversation
…lock-minutes) The daemon hardcoded the per-run budget (DaemonConfig: 20 iterations / 45 min) with no CLI override, so a feature-class issue that needs more than 45 min times out at needs_triage every run. Add --max-iterations-per-run and --max-wall-clock-minutes-per-run to the daemon subcommand (default to the existing conservative values), so a one-off larger run can be triggered without touching the timer's defaults. Surfaced by the VPS launch-proof dogfood (hyrule-cloud#28): the loop wrote ~1083 lines of good, on-spec code but ran out of the 45-min wall clock. Validation: ruff clean, mypy --strict clean, 177 passed (+1), evals 15/15. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The VPS launch-proof dogfood (hyrule-cloud#28) showed the loop writes good, on-spec code but times out at the 45-min wall clock on a feature this size — every run ends
needs_triagewith partial work. The per-run budget (DaemonConfig: 20 iterations / 45 min) had no CLI override on thedaemonsubcommand.Change
Add
--max-iterations-per-runand--max-wall-clock-minutes-per-runtodaemon, defaulting to the existing conservativeDaemonConfigvalues and wired into the config. This lets a one-off larger run be triggered (e.g. 90 min) without changing the timer's defaults.Validation
uvx ruff check src tests— cleanuv run --group dev mypy --strict src— cleanuv run --group dev pytest -q— 177 passed (+1: defaults + override parse)daemon --helpshows both flagsNext
Merge → bump the loop pin → re-queue #28 → manual run with
--max-wall-clock-minutes-per-run 90so the loop finishes the launch-proof contract to a real draft PR. The hourly timer stays at the 45-min default.