Add host-aware FluentFTP config callback to factories#739
Merged
Conversation
Co-authored-by: AndreaCuneo <5227688+AndreaCuneo@users.noreply.github.com>
Co-authored-by: AndreaCuneo <5227688+AndreaCuneo@users.noreply.github.com>
Copilot
AI
changed the title
feat(FluentFtp): add host-aware config callback
Add host-aware FluentFTP config callback to factories
Jun 30, 2026
Copilot created this pull request from a session on behalf of
AndreaCuneo
June 30, 2026 12:25
View session
| connectionFactoryField.Should().NotBeNull(); | ||
|
|
||
| var connectionFactory = connectionFactoryField!.GetValue(ftpClientFactory) as IFtpClientConnectionFactory; | ||
| connectionFactory.Should().NotBeNull(); |
…null' Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com> Signed-off-by: Andrea Cuneo <kaildio@gmail.com>
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com> Signed-off-by: Andrea Cuneo <kaildio@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FluentFTP client creation could not be customized per target FTP host. This change adds a host-aware configuration callback so callers can mutate
FluentFTP.FtpConfigduring client construction in both pooled and non-pooled flows.What changed
FluentFtpClientFactoryandFluentFtpClientPoolFactoryaccepting:FluentFtpClientConnectionFactoryintoFluentFtpClientConnection.AsyncFtpClientcreation, with the FTP host passed alongside the mutableFluentFTP.FtpConfig.Behavior
API shape
Scope