refactor(build): default to a full provisioned build; add --fast - #111
Merged
Conversation
build.sh's --clean and --provision were opt-in, so the common and
correctness-critical case (a provisioned, ship-ready image with ARK-OS
and the pinned camera stack) needed two flags, while the rare case (a
quick kernel-only rebuild) was the flagless default. Forgetting the
flags silently produced a stock, unprovisioned image.
Invert it: a bare `./build.sh <TARGET>` now wipes staging, re-stages,
provisions, and builds. Two opt-outs cover the rest:
--fast reuse the existing staged tree, recompile only; errors
if nothing is staged, so it can't silently ship stock
--no-provision fresh stage + build, skip provisioning (compile-check)
--clean/--provision stay accepted as no-ops. CI's PR/main compile-check
moves to --no-provision so it doesn't provision (or hit the network) on
every push; tag builds keep --provision explicit.
Collaborator
Author
|
@HumphreyGremsySolutions this should help |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Invert
build.sh's defaults so a bare./build.sh <TARGET>produces a full, provisioned, ship-ready image. Quick rebuilds and bare images become explicit opt-outs (--fast,--no-provision).Problem
--cleanand--provisionwere opt-in, so the common and correctness-critical case — a provisioned image with ARK-OS and the pinned camera stack — required remembering two flags, while the rare case (a fast kernel-only rebuild) was the flagless default. Forgetting the flags silently produced a stock, unprovisioned image, and--provisionon an already-staged tree quietly no-op'd. This is the class of confusion behind #110: a build that ships the stock 36.5.0 camera stack instead of the pinned+ark1one.Solution
The default is now clean + provision + build. Two opt-outs:
--fast— reuse the existing staged tree, recompile the kernel/device tree only. Errors if nothing is staged, so it can't silently ship an unprovisioned image.--no-provision— fresh stage + build, skip provisioning (the compile-check path).--clean/--provisionremain accepted as harmless no-ops. CI's PR/main compile-check moves to--no-provisionso it no longer provisions (or hits NVIDIA/GitHub) on every push; tag builds keep--provisionexplicit. Comments and docs referencing the old opt-in flags are updated to match.