[cclauss]

What this does

perflint: Add ruff rules for performance -- https://docs.astral.sh/ruff/rules/#perflint-perf

---

How it was tested

% pre-commit run --all-files

% ruff rule PERF401

manual-list-comprehension (PERF401)

Derived from the Perflint linter.

Fix is sometimes available.

What it does

Checks for for loops that can be replaced by a list comprehension.

Why is this bad?

When creating a transformed list from an existing list using a for-loop,
prefer a list comprehension. List comprehensions are more readable and
more performant.

Using the below as an example, the list comprehension is ~10% faster on
Python 3.11, and ~25% faster on Python 3.10.

Note that, as with all perflint rules, this is only intended as a
micro-optimization, and will have a negligible impact on performance in
most cases.

Example

original = list(range(10000))
filtered = []
for i in original:
    if i % 2:
        filtered.append(i)

Use instead:

original = list(range(10000))
filtered = [x for x in original if x % 2]

If you're appending to an existing list, use the extend method instead:

original = list(range(10000))
filtered.extend(x for x in original if x % 2)

[Copilot]

Pull Request Overview

This PR adds Ruff's perflint performance rules to improve code efficiency by addressing common performance anti-patterns. The changes focus on optimizing dictionary/list operations and reducing unnecessary iterations.

• Replaced dict.items() with dict.values() when keys aren't used
• Converted manual list building loops to list comprehensions
• Added perflint rules to the linting configuration

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
pyproject.toml	Added PERF rules to Ruff configuration with selective ignores
src/beavr/teleop/components/operator/solvers/leap_solver.py	Added noqa comment for dictionary assignment in loop
src/beavr/lerobot/configs/policies.py	Optimized dictionary iteration by using .values()
src/beavr/lerobot/common/robot_devices/robots/mobile_manipulator.py	Replaced manual list building with list comprehensions
src/beavr/lerobot/common/robot_devices/robots/manipulator.py	Converted loops to list comprehensions for state/action creation
src/beavr/lerobot/common/robot_devices/robots/beavrbot.py	Optimized dictionary iteration by using .values()
src/beavr/lerobot/common/robot_devices/cameras/opencv.py	Refactored camera finding logic with list comprehensions
src/beavr/lerobot/common/policies/smolvla/smolvlm_with_expert.py	Replaced append loop with list.extend() and generator expression

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

The Linux branch returns early, but the non-Linux code now runs unconditionally. This should be wrapped in an else block to maintain the original behavior.

[cclauss]

That would violate ruff rule RET505.

• https://docs.astral.sh/ruff/rules/superfluous-else-return

The else statement is not needed as the return statement will always break out of the enclosing function. Removing the else will reduce nesting and make the code more readable.

[cclauss]

Keep these sorted to make it easy to spot missing rules and nearly impossible to add duplicates.

[Copilot]

Pull Request Overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

The function signature indicates it returns list[dict] but the implementation has two different return paths that may not execute. After the Linux block, there's no else clause, so the Mac/Windows code will always execute regardless of platform, potentially causing the Linux case to return twice or fall through incorrectly.

[cclauss]

Both possible paths return a list[dict]. The fall through is correct because Mac/Windows code will never execute in the Linux case and the Linux code will never execute in the Mac/Windows case. Returning twice is not possible in Python code because the first return leaves the function.

[Copilot]

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The refactoring removed the early return logic and changed the control flow. The raise_when_empty parameter is no longer being passed to the _find_cameras function calls. The original code had implicit fall-through to the else block, but now when the Linux branch returns early, the function doesn't handle the raise_when_empty parameter for either path.

[Copilot]

The refactoring removed the early return logic and changed the control flow. The raise_when_empty parameter is no longer being passed to the _find_cameras function call. The original code passed this parameter through, but now it's missing.