package name: com.ogh.app - #4
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (34)
📝 WalkthroughWalkthroughChangesApplication identity migration
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested reviewers: ✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR renames the Android app’s package identity from com.ogh.app to org.aossie.ogh, updating the Gradle namespace/applicationId, OAuth redirect scheme, documentation, and Maestro flows so the app and its automation/tests continue to align.
Changes:
- Updated Android
namespace/applicationIdand AppAuth redirect scheme toorg.aossie.ogh. - Renamed Kotlin packages/imports across
androidAppmain + test sources toorg.aossie.ogh…. - Updated documentation, Maestro
appId, and rotated the public YouTube client ID in resources.
Reviewed changes
Copilot reviewed 34 out of 34 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| SPECIFICATION.md | Updates documented app ID / OAuth redirect identity to org.aossie.ogh. |
| OAUTH_SETUP.md | Updates Google OAuth setup instructions and redirect URI scheme. |
| DECISIONS.md | Updates architectural decision text referencing the redirect URI scheme. |
| androidApp/src/test/kotlin/com/ogh/app/StreamViewModelTest.kt | Updates test package/imports to new org.aossie.ogh… namespace. |
| androidApp/src/test/kotlin/com/ogh/app/oauth/YouTubeApiClientTest.kt | Updates test package to org.aossie.ogh.oauth. |
| androidApp/src/test/kotlin/com/ogh/app/oauth/TwitchDeviceAuthClientTest.kt | Updates test package to org.aossie.ogh.oauth. |
| androidApp/src/test/kotlin/com/ogh/app/oauth/OAuthConfigTest.kt | Updates test package and redirect URI assertion. |
| androidApp/src/test/kotlin/com/ogh/app/oauth/GoogleTokenRevokerTest.kt | Updates test package to org.aossie.ogh.oauth. |
| androidApp/src/test/kotlin/com/ogh/app/data/SettingsJsonCodecTest.kt | Updates test package to org.aossie.ogh.data. |
| androidApp/src/test/kotlin/com/ogh/app/data/DestinationJsonCodecTest.kt | Updates test package to org.aossie.ogh.data. |
| androidApp/src/test/kotlin/com/ogh/app/CameraSourceCatalogTest.kt | Updates test package to org.aossie.ogh. |
| androidApp/src/main/res/values/strings.xml | Updates public YouTube OAuth client ID. |
| androidApp/src/main/kotlin/com/ogh/app/viewmodel/StreamViewModel.kt | Updates package/imports to org.aossie.ogh.viewmodel. |
| androidApp/src/main/kotlin/com/ogh/app/ui/StreamPreview.kt | Updates package/imports to org.aossie.ogh.ui. |
| androidApp/src/main/kotlin/com/ogh/app/ScreenCaptureService.kt | Updates package to org.aossie.ogh. |
| androidApp/src/main/kotlin/com/ogh/app/ReusableScreenSource.kt | Updates package to org.aossie.ogh. |
| androidApp/src/main/kotlin/com/ogh/app/PhysicalOrientationTracker.kt | Updates package to org.aossie.ogh. |
| androidApp/src/main/kotlin/com/ogh/app/PauseSlateFactory.kt | Updates package to org.aossie.ogh. |
| androidApp/src/main/kotlin/com/ogh/app/oauth/YouTubeApiClient.kt | Updates package to org.aossie.ogh.oauth. |
| androidApp/src/main/kotlin/com/ogh/app/oauth/TwitchDeviceAuthClient.kt | Updates package to org.aossie.ogh.oauth. |
| androidApp/src/main/kotlin/com/ogh/app/oauth/TokenManager.kt | Updates package to org.aossie.ogh.oauth. |
| androidApp/src/main/kotlin/com/ogh/app/oauth/OAuthManager.kt | Updates package to org.aossie.ogh.oauth. |
| androidApp/src/main/kotlin/com/ogh/app/oauth/OAuthConfig.kt | Updates package, R import, and redirect URI constant. |
| androidApp/src/main/kotlin/com/ogh/app/oauth/GoogleTokenRevoker.kt | Updates package to org.aossie.ogh.oauth. |
| androidApp/src/main/kotlin/com/ogh/app/oauth/AndroidKeystoreTokenStorage.kt | Updates package to org.aossie.ogh.oauth. |
| androidApp/src/main/kotlin/com/ogh/app/MainActivity.kt | Updates package and imports to org.aossie.ogh…. |
| androidApp/src/main/kotlin/com/ogh/app/data/SettingsRepository.kt | Updates package to org.aossie.ogh.data. |
| androidApp/src/main/kotlin/com/ogh/app/data/SecureDestinationStorage.kt | Updates package/imports to org.aossie.ogh.data. |
| androidApp/src/main/AndroidManifest.xml | Updates AppAuth redirect scheme to org.aossie.ogh. |
| androidApp/build.gradle.kts | Updates Android namespace and applicationId to org.aossie.ogh. |
| .maestro/flows/youtube-authorization-page.yaml | Updates Maestro appId to org.aossie.ogh. |
| .maestro/flows/twitch-authorization-page.yaml | Updates Maestro appId to org.aossie.ogh. |
| .maestro/flows/destination-crud.yaml | Updates Maestro appId to org.aossie.ogh. |
| .maestro/flows/app-navigation.yaml | Updates Maestro appId to org.aossie.ogh. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| namespace = "org.aossie.ogh" | ||
| compileSdk = (findProperty("android.compileSdk") as String).toInt() | ||
|
|
||
| defaultConfig { | ||
| applicationId = "com.ogh.app" | ||
| applicationId = "org.aossie.ogh" |
| @@ -1,4 +1,4 @@ | |||
| package com.ogh.app | |||
| package org.aossie.ogh | |||
Summary by CodeRabbit
Configuration
Documentation
Tests