Skip to content

package name: com.ogh.app - #4

Merged
imxade merged 1 commit into
masterfrom
org.aossie.ogh
Aug 3, 2026
Merged

package name: com.ogh.app#4
imxade merged 1 commit into
masterfrom
org.aossie.ogh

Conversation

@imxade

@imxade imxade commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Configuration

    • Updated the Android app identity and OAuth redirect scheme.
    • Refreshed YouTube OAuth configuration to support the updated app identity.
  • Documentation

    • Updated setup instructions and specifications with the new OAuth redirect details.
  • Tests

    • Updated automated navigation, authorization, and application tests to use the revised app identity.

Copilot AI review requested due to automatic review settings August 3, 2026 11:31
@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 50e55f44-3b8a-41c0-90b9-e664bdaaf43f

📥 Commits

Reviewing files that changed from the base of the PR and between 5a15517 and 73bcd3e.

📒 Files selected for processing (34)
  • .maestro/flows/app-navigation.yaml
  • .maestro/flows/destination-crud.yaml
  • .maestro/flows/twitch-authorization-page.yaml
  • .maestro/flows/youtube-authorization-page.yaml
  • DECISIONS.md
  • OAUTH_SETUP.md
  • SPECIFICATION.md
  • androidApp/build.gradle.kts
  • androidApp/src/main/AndroidManifest.xml
  • androidApp/src/main/kotlin/com/ogh/app/MainActivity.kt
  • androidApp/src/main/kotlin/com/ogh/app/PauseSlateFactory.kt
  • androidApp/src/main/kotlin/com/ogh/app/PhysicalOrientationTracker.kt
  • androidApp/src/main/kotlin/com/ogh/app/ReusableScreenSource.kt
  • androidApp/src/main/kotlin/com/ogh/app/ScreenCaptureService.kt
  • androidApp/src/main/kotlin/com/ogh/app/data/SecureDestinationStorage.kt
  • androidApp/src/main/kotlin/com/ogh/app/data/SettingsRepository.kt
  • androidApp/src/main/kotlin/com/ogh/app/oauth/AndroidKeystoreTokenStorage.kt
  • androidApp/src/main/kotlin/com/ogh/app/oauth/GoogleTokenRevoker.kt
  • androidApp/src/main/kotlin/com/ogh/app/oauth/OAuthConfig.kt
  • androidApp/src/main/kotlin/com/ogh/app/oauth/OAuthManager.kt
  • androidApp/src/main/kotlin/com/ogh/app/oauth/TokenManager.kt
  • androidApp/src/main/kotlin/com/ogh/app/oauth/TwitchDeviceAuthClient.kt
  • androidApp/src/main/kotlin/com/ogh/app/oauth/YouTubeApiClient.kt
  • androidApp/src/main/kotlin/com/ogh/app/ui/StreamPreview.kt
  • androidApp/src/main/kotlin/com/ogh/app/viewmodel/StreamViewModel.kt
  • androidApp/src/main/res/values/strings.xml
  • androidApp/src/test/kotlin/com/ogh/app/CameraSourceCatalogTest.kt
  • androidApp/src/test/kotlin/com/ogh/app/StreamViewModelTest.kt
  • androidApp/src/test/kotlin/com/ogh/app/data/DestinationJsonCodecTest.kt
  • androidApp/src/test/kotlin/com/ogh/app/data/SettingsJsonCodecTest.kt
  • androidApp/src/test/kotlin/com/ogh/app/oauth/GoogleTokenRevokerTest.kt
  • androidApp/src/test/kotlin/com/ogh/app/oauth/OAuthConfigTest.kt
  • androidApp/src/test/kotlin/com/ogh/app/oauth/TwitchDeviceAuthClientTest.kt
  • androidApp/src/test/kotlin/com/ogh/app/oauth/YouTubeApiClientTest.kt

📝 Walkthrough

Walkthrough

Changes

Application identity migration

Layer / File(s) Summary
Android identity and package migration
androidApp/build.gradle.kts, androidApp/src/main/kotlin/com/ogh/app/...
The Android namespace, application ID, Kotlin packages, and imports now use org.aossie.ogh.
OAuth redirect alignment
androidApp/src/main/AndroidManifest.xml, androidApp/src/main/kotlin/com/ogh/app/oauth/..., androidApp/src/main/res/values/strings.xml
OAuth redirect handling and configuration now use the new application identity.
Package migration validation
androidApp/src/test/kotlin/com/ogh/app/...
Tests now use the renamed packages and updated redirect URI.
Documentation and Maestro flow updates
DECISIONS.md, OAUTH_SETUP.md, SPECIFICATION.md, .maestro/flows/*
Documentation and Maestro flows now reference the new application ID and OAuth redirect URI.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: copilot

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@imxade
imxade merged commit fcff204 into master Aug 3, 2026
6 of 7 checks passed
@imxade
imxade deleted the org.aossie.ogh branch August 3, 2026 11:31

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR renames the Android app’s package identity from com.ogh.app to org.aossie.ogh, updating the Gradle namespace/applicationId, OAuth redirect scheme, documentation, and Maestro flows so the app and its automation/tests continue to align.

Changes:

  • Updated Android namespace/applicationId and AppAuth redirect scheme to org.aossie.ogh.
  • Renamed Kotlin packages/imports across androidApp main + test sources to org.aossie.ogh….
  • Updated documentation, Maestro appId, and rotated the public YouTube client ID in resources.

Reviewed changes

Copilot reviewed 34 out of 34 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
SPECIFICATION.md Updates documented app ID / OAuth redirect identity to org.aossie.ogh.
OAUTH_SETUP.md Updates Google OAuth setup instructions and redirect URI scheme.
DECISIONS.md Updates architectural decision text referencing the redirect URI scheme.
androidApp/src/test/kotlin/com/ogh/app/StreamViewModelTest.kt Updates test package/imports to new org.aossie.ogh… namespace.
androidApp/src/test/kotlin/com/ogh/app/oauth/YouTubeApiClientTest.kt Updates test package to org.aossie.ogh.oauth.
androidApp/src/test/kotlin/com/ogh/app/oauth/TwitchDeviceAuthClientTest.kt Updates test package to org.aossie.ogh.oauth.
androidApp/src/test/kotlin/com/ogh/app/oauth/OAuthConfigTest.kt Updates test package and redirect URI assertion.
androidApp/src/test/kotlin/com/ogh/app/oauth/GoogleTokenRevokerTest.kt Updates test package to org.aossie.ogh.oauth.
androidApp/src/test/kotlin/com/ogh/app/data/SettingsJsonCodecTest.kt Updates test package to org.aossie.ogh.data.
androidApp/src/test/kotlin/com/ogh/app/data/DestinationJsonCodecTest.kt Updates test package to org.aossie.ogh.data.
androidApp/src/test/kotlin/com/ogh/app/CameraSourceCatalogTest.kt Updates test package to org.aossie.ogh.
androidApp/src/main/res/values/strings.xml Updates public YouTube OAuth client ID.
androidApp/src/main/kotlin/com/ogh/app/viewmodel/StreamViewModel.kt Updates package/imports to org.aossie.ogh.viewmodel.
androidApp/src/main/kotlin/com/ogh/app/ui/StreamPreview.kt Updates package/imports to org.aossie.ogh.ui.
androidApp/src/main/kotlin/com/ogh/app/ScreenCaptureService.kt Updates package to org.aossie.ogh.
androidApp/src/main/kotlin/com/ogh/app/ReusableScreenSource.kt Updates package to org.aossie.ogh.
androidApp/src/main/kotlin/com/ogh/app/PhysicalOrientationTracker.kt Updates package to org.aossie.ogh.
androidApp/src/main/kotlin/com/ogh/app/PauseSlateFactory.kt Updates package to org.aossie.ogh.
androidApp/src/main/kotlin/com/ogh/app/oauth/YouTubeApiClient.kt Updates package to org.aossie.ogh.oauth.
androidApp/src/main/kotlin/com/ogh/app/oauth/TwitchDeviceAuthClient.kt Updates package to org.aossie.ogh.oauth.
androidApp/src/main/kotlin/com/ogh/app/oauth/TokenManager.kt Updates package to org.aossie.ogh.oauth.
androidApp/src/main/kotlin/com/ogh/app/oauth/OAuthManager.kt Updates package to org.aossie.ogh.oauth.
androidApp/src/main/kotlin/com/ogh/app/oauth/OAuthConfig.kt Updates package, R import, and redirect URI constant.
androidApp/src/main/kotlin/com/ogh/app/oauth/GoogleTokenRevoker.kt Updates package to org.aossie.ogh.oauth.
androidApp/src/main/kotlin/com/ogh/app/oauth/AndroidKeystoreTokenStorage.kt Updates package to org.aossie.ogh.oauth.
androidApp/src/main/kotlin/com/ogh/app/MainActivity.kt Updates package and imports to org.aossie.ogh….
androidApp/src/main/kotlin/com/ogh/app/data/SettingsRepository.kt Updates package to org.aossie.ogh.data.
androidApp/src/main/kotlin/com/ogh/app/data/SecureDestinationStorage.kt Updates package/imports to org.aossie.ogh.data.
androidApp/src/main/AndroidManifest.xml Updates AppAuth redirect scheme to org.aossie.ogh.
androidApp/build.gradle.kts Updates Android namespace and applicationId to org.aossie.ogh.
.maestro/flows/youtube-authorization-page.yaml Updates Maestro appId to org.aossie.ogh.
.maestro/flows/twitch-authorization-page.yaml Updates Maestro appId to org.aossie.ogh.
.maestro/flows/destination-crud.yaml Updates Maestro appId to org.aossie.ogh.
.maestro/flows/app-navigation.yaml Updates Maestro appId to org.aossie.ogh.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +29 to +33
namespace = "org.aossie.ogh"
compileSdk = (findProperty("android.compileSdk") as String).toInt()

defaultConfig {
applicationId = "com.ogh.app"
applicationId = "org.aossie.ogh"
@@ -1,4 +1,4 @@
package com.ogh.app
package org.aossie.ogh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants