deps: allow Qyl.* prereleases through default-deny#32
Conversation
Mirrors the existing /^ANcpLua\./ exception in the "Known-prerelease NuGet exceptions" rule so the in-progress rename of the analyzer package family from ANcpLua.* to Qyl.* does not regress downstream consumers extending this preset. Without this entry, Qyl.* packages would be subject to the default-deny on alpha/beta/preview/pre/dev suffixes and consumers would lose access to legitimate prerelease pins once the cutover lands.
|
@coderabbitai autofix |
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
Note Autofix is a beta feature. Expect some limitations and changes as we gather feedback and continue to improve it. Autofix skipped. No unresolved CodeRabbit review comments with fix instructions found. |
Up to standards ✅🟢 Issues
|
![codacy-production[bot]](https://avatars.githubusercontent.com/in/56611?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull Request Overview
The PR updates the Renovate configuration to allow Qyl.* prereleases, which is necessary for the ANcpLua.* package family rename. While the primary requirement is met, the implementation is incomplete regarding automation. Codacy reports the PR as up to standards.
The review identified a gap in the automerge configuration. Since Qyl.* is replacing ANcpLua.*, it should inherit the same automerge logic for minor and patch releases to avoid manual intervention overhead. Without this, the team will experience a regression in how dependency updates are handled for this package family.
About this PR
- While this PR adds the prerelease exception, it does not update the automerge rule for first-party packages (lines 61-66). Since 'Qyl.' is a rename of 'ANcpLua.', this omission will result in a regression where minor and patch updates for the new package family require manual approval instead of being automerged.
Test suggestions
- Verify that NuGet packages prefixed with 'Qyl.' are permitted to resolve to prerelease versions (*).
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify that NuGet packages prefixed with 'Qyl.' are permitted to resolve to prerelease versions (*).
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
| "matchDatasources": ["nuget"], | ||
| "matchPackageNames": [ | ||
| "/^ANcpLua\\./", | ||
| "/^Qyl\\./", |
There was a problem hiding this comment.
🟡 MEDIUM RISK
Suggestion: The 'ANcpLua.*' prefix also has a specific automerge rule at line 62. Since this is a package family rename, you should likely add '/^Qyl./' to that rule as well to ensure parity and avoid manual overhead for minor/patch updates.
There was a problem hiding this comment.
Pull request overview
This PR updates the shared Renovate preset to exempt the Qyl.* NuGet package family from the default prerelease denylist, mirroring the existing exception for ANcpLua.* so downstream consumers can continue using legitimate prerelease pins during the package-family rename.
Changes:
- Added
/^Qyl\./to the NuGet “Known-prerelease exceptions” allowlist so prerelease versions aren’t blocked by the global NuGet default-deny rule.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "description": "Known-prerelease NuGet exceptions: first-party packages plus upstreams with no stable release. Resets allowedVersions so the default-deny does not freeze legitimate prerelease pins", | ||
| "matchDatasources": ["nuget"], | ||
| "matchPackageNames": [ | ||
| "/^ANcpLua\\./", | ||
| "/^Qyl\\./", | ||
| "Microsoft.OpenApi.Readers", |
Mirrors the existing
/^ANcpLua\./exception in the "Known-prerelease NuGet exceptions" rule so the in-progress rename of the analyzer package family fromANcpLua.*toQyl.*does not regress downstream consumers extending this preset.Without this entry,
Qyl.*packages would be subject to the default-deny on alpha/beta/preview/pre/dev/experimental/nightly suffixes, and consumers would lose access to legitimate prerelease pins once the cutover lands.Diff
"matchPackageNames": [ "/^ANcpLua\\./", + "/^Qyl\\./", "Microsoft.OpenApi.Readers", "JonSkeet.RoslynAnalyzers" ],CodeRabbit + the fleet's auto-merge tier handles merge post-review — not enabling auto-merge here.