deps: Update ancplua-sdk to 2.2.42#535
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ed5e50b71a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| "ANcpLua.Roslyn.Utilities.Testing": "2.2.40", | ||
| "ANcpLua.Roslyn.Utilities": "2.2.40" |
There was a problem hiding this comment.
Keep Roslyn utility pins in lockstep
This updates only the MSBuild SDK resolver entries, but the projects that compile against these utilities still get their PackageReference versions from Directory.Packages.props via Version.props, where ANcpLuaRoslynUtilitiesVersion remains 2.2.39. In builds of internal/qyl.instrumentation / the generator projects, that leaves the actual ANcpLua.Roslyn.Utilities and .Sources package references on the old version while the global SDK pin is 2.2.40, so this dependency update either does not test the intended package version or mixes SDK/package artifacts if both are resolved. Please update the shared package-version property in the same change.
Useful? React with 👍 / 👎.
b4fcb21 to
ba1bfe5
Compare
7b2ba6f to
53f1074
Compare
16e03ae to
5198298
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5198298412
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| "ANcpLua.Roslyn.Utilities.Testing": "2.2.42", | ||
| "ANcpLua.Roslyn.Utilities": "2.2.42" |
There was a problem hiding this comment.
Update the package pin with the SDK pin
Fresh evidence in the current tree is that these SDK pins move to 2.2.42 while Version.props still sets ANcpLuaRoslynUtilitiesVersion to 2.2.41, and Directory.Packages.props feeds that property to the ANcpLua.Roslyn.Utilities and .Sources package references used by the instrumentation/generator projects. That means those projects still restore 2.2.41 while global.json resolves the MSBuild SDK at 2.2.42, so this dependency update does not exercise the requested package version and can mix SDK/package artifacts; update the shared property in the same change.
AGENTS.md reference: AGENTS.md:L56-L58
Useful? React with 👍 / 👎.
5198298 to
6614048
Compare
This PR contains the following updates:
2.2.39→2.2.422.2.39→2.2.42Release Notes
ANcpLua/ANcpLua.Roslyn.Utilities (ANcpLua.Roslyn.Utilities)
v2.2.42Full Changelog: ANcpLua/ANcpLua.Roslyn.Utilities@v2.2.41...v2.2.42
v2.2.41What's Changed
Full Changelog: ANcpLua/ANcpLua.Roslyn.Utilities@v2.2.40...v2.2.41
v2.2.40Full Changelog: ANcpLua/ANcpLua.Roslyn.Utilities@v2.2.39...v2.2.40
Configuration
📅 Schedule: (in timezone UTC)
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.