deps: Update dependency Microsoft.Build to 18.8.2#533
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ca50517edb
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| { | ||
| "sdk": { | ||
| "version": "10.0.301", | ||
| "version": "10.0.302", |
There was a problem hiding this comment.
For a push to main after 0.1.0-beta.2 has been published/tagged, this SDK bump changes a path that the NuGet trusted-publishing workflow treats as package-owned: the publish gate diffs global.json in .github/workflows/nuget-publish.yml lines 277-289, then rejects a publish when the existing v$VERSION tag or NuGet package belongs to a different commit. Because Version.props still declares 0.1.0-beta.2, merging this by itself will make the publish job fail with the workflow's “bump QylVersion” guard instead of completing the release path.
Useful? React with 👍 / 👎.
| { | ||
| "sdk": { | ||
| "version": "10.0.301", | ||
| "version": "10.0.302", |
There was a problem hiding this comment.
After this line selects SDK 10.0.302, AGENTS.md line 86 still tells agents and contributors that the repository toolchain is the global.json SDK 10.0.301 with latestFeature. Anyone following that repository contract after this merge gets conflicting instructions about which SDK is allowed, so the SDK bump should update the contract in the same change instead of leaving future edits/reviews pinned back to 10.0.301.
Useful? React with 👍 / 👎.
c63a36d to
eaf74f1
Compare
renovate
Bot
changed the title
eaf74f1 to
8fa2544
Compare
renovate
Bot
changed the title
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8fa2544f36
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| <PackageVersion Include="McMaster.Extensions.CommandLineUtils" Version="5.1.0"/> | ||
| <!-- Nuke.ProjectModel requires this floor under transitive pinning. --> | ||
| <PackageVersion Include="Microsoft.Build" Version="18.7.1"/> | ||
| <PackageVersion Include="Microsoft.Build" Version="18.8.2"/> |
There was a problem hiding this comment.
If 0.1.0-beta.9 has already been published from the release commit in this branch, this dependency bump creates another package-owned change without updating Version.props: .github/workflows/nuget-publish.yml diffs Directory.Packages.props in the publish gate, then rejects an existing tag/package for the same version when it belongs to a different commit. That means a push to main would try to republish immutable beta.9 packages and fail instead of releasing this update; bump QylVersion with the dependency change.
Useful? React with 👍 / 👎.
This PR contains the following updates:
18.7.1→18.8.2Release Notes
dotnet/msbuild (Microsoft.Build)
v18.8.2What's Changed
1292181by @dotnet-bot in #128971406429by @dotnet-bot in #135961415925by @dotnet-bot in #138161416757by @dotnet-bot in #138391416940by @dotnet-bot in #13843Full Changelog: dotnet/msbuild@v18.7.1...v18.8.2
Configuration
📅 Schedule: (in timezone UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.