deps: Update ancplua-sdk to 2.2.40#197
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c31afa847e
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| "ANcpLua.Roslyn.Utilities.Testing": "2.2.39", | ||
| "ANcpLua.Roslyn.Utilities": "2.2.39" |
There was a problem hiding this comment.
When this dependency update is merged, the Roslyn.Utilities and Testing package references still resolve to 2.2.37: all checked projects use Sdk="ANcpLua.NET.Sdk" or Microsoft.NET.Sdk, while Directory.Packages.props takes ANcpLua.Roslyn.Utilities and .Testing versions from Version.props (ANcpLuaRoslynUtilitiesVersion / ANcpLuaRoslynUtilitiesTestingVersion). These global.json msbuild-sdks entries are only consulted for MSBuild SDK resolution, so the 2.2.39 fixes are not actually used by the analyzer or test projects unless the local Version.props overrides are bumped or pruned.
Useful? React with 👍 / 👎.
| "ANcpLua.NET.Sdk.Test": "3.4.43", | ||
| "ANcpLua.Roslyn.Utilities.Testing": "2.2.38", | ||
| "ANcpLua.Roslyn.Utilities": "2.2.38" | ||
| "ANcpLua.NET.Sdk": "3.4.44", |
There was a problem hiding this comment.
With the SDK moved to 3.4.44, its dependency sweep also moves the SDK-injected ANcpLua.Analyzers package from 2.1.0 to 2.1.1, but this repo still has a later CPM override at Directory.Packages.props fed by Version.props (ANcpLuaAnalyzersVersion=2.1.0). For the analyzer/test projects that use Sdk="ANcpLua.NET.Sdk", restore will keep dogfooding 2.1.0 instead of the analyzer fixes shipped with 3.4.44 unless the local override is pruned or bumped.
Useful? React with 👍 / 👎.
renovate
Bot
changed the title
renovate
Bot
changed the title
c31afa8 to
c44a5ba
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c44a5ba3f6
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| "ANcpLua.Roslyn.Utilities.Testing": "2.2.40", | ||
| "ANcpLua.Roslyn.Utilities": "2.2.40" |
There was a problem hiding this comment.
In this revision the global.json MSBuild SDK entries move to 2.2.40, but the analyzer and test projects consume ANcpLua.Roslyn.Utilities/.Testing through PackageReferences governed by Directory.Packages.props, which reads Version.props; fresh evidence is that Version.props still pins both package-version properties to 2.2.39. As a result, restore for the repo continues using the 2.2.39 runtime/test packages, so any 2.2.40 fixes are not actually dogfooded unless those local CPM overrides are bumped or removed.
Useful? React with 👍 / 👎.
This PR contains the following updates:
2.2.39→2.2.402.2.39→2.2.40Release Notes
ANcpLua/ANcpLua.Roslyn.Utilities (ANcpLua.Roslyn.Utilities)
v2.2.40Full Changelog: ANcpLua/ANcpLua.Roslyn.Utilities@v2.2.39...v2.2.40
Configuration
📅 Schedule: (in timezone UTC)
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.