Update list branch#2
Conversation
Strangeal
left a comment
Strangeal
left a comment
There was a problem hiding this comment.
Hi @ANTOINE1128,
Great work on making the changes requested by a previous reviewer 👏
You've done well implementing some of the requested changes, but there are still some which aren't addressed yet.
Required Changes ♻️
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
| body { | ||
| background-color: rgba(183, 164, 164, 0.986); | ||
| } |
There was a problem hiding this comment.
- kindly consider taking a second look at your CSS loader as unsure what exactly the problem might be but your style.css isn't loading and due to that your page looks like you didn't add any styles at all. Fixing the styles issue will make your design more attractive to your user and create a good user experience. See below for more details:
| "main": "index.js", | ||
| "scripts": { | ||
| "build": "webpack", | ||
| "start:dev": "webpack-dev-server", |
There was a problem hiding this comment.
- Kindly consider setting your
startproperly so anyone who clones your repository will be able to start up the project and see the great work you've done. The command should be"start": "webpack-dev-server"not"start:dev": "webpack-dev-server"
iambenkis
left a comment
iambenkis
left a comment
There was a problem hiding this comment.
Hi @ANTOINE1128 ,
Your project is complete! There is nothing else to say other than... it's time to merge it 
Congratulations! 🎉
Highlights
- Descriptive pull request message with screenshots ✔️
- Well organized project ✔️
Status: Approved ✔️✔️✔️
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100%.
Please, remember to tag me @iambenkis in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
3 participants
in this project, I have done the following 👍 :