Add LLVM Flang CI - #5614
Open
muk2 wants to merge 1 commit into
Open
Conversation
Add a Linux CI job that builds libamrex and its Fortran interfaces with LLVM Flang (and matching Clang). This catches LLVM-Flang-specific Fortran compile errors such as the duplicate `public` attribute fixed in AMReX-Codes#5604, which gfortran-based CI does not flag. Closes AMReX-Codes#5605. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Member
|
Just for testing, can we revert the change in #5604 to see if the CI covers it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a Linux CI workflow that builds libamrex and its Fortran interfaces with LLVM Flang, addressing #5605.
The existing Clang CI compiles C++ with Clang but still uses
gfortranfor Fortran, so it cannot catch LLVM-Flang-specific Fortran errors — e.g. the duplicatepublicattribute inAMReX_fillpatch_mod.F90that was fixed in #5604 (#5603). This new job builds withflang(and matchingclang/clang++) with-DAMReX_FORTRAN_INTERFACES=ON, so such regressions are caught going forward.Changes
.github/workflows/flang.yml— newLinuxFlangworkflow. Builds/installs libamrex + Fortran interfaces with LLVM Flang 20 (NOMPI, Debug, EB + Fortran interfaces on). Uses the sharedcheck_changesgate to skip docs-only PRs..github/workflows/dependencies/dependencies_flang.sh— installsflang/clangfrom apt.llvm.org.Checklist
The proposed changes: