Certificate Format Updates#258
Conversation
Also improve cert markdown report headings and test table.
Add os_info module to detect OS name/version from /etc/os-release on both host (local file) and guest (via vsock). Display OS info in CLI output and include it in the markdown report environment section. Signed-off-by: Harika Nittala <lnittala@amd.com>
97863ef to
7d63ff0
Compare
There was a problem hiding this comment.
Pull request overview
This PR extends the certification reporting pipeline to capture and emit host/guest environment details (OS/kernel/QEMU/OVMF) so certification results record the software context used during a run.
Changes:
- Added host environment detection (OS, kernel, QEMU, OVMF) and plumbed an
environmentdict through CLI execution and report writers. - Added guest OS detection via vsock and updates the shared
environmentdict after a successful VM launch. - Updated Markdown/JSON outputs to include the detected environment metadata, and refactored OVMF path discovery into a helper.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| sev_verify/vm_profile.py | Adds find_ovmf_path() helper and reuses it when resolving OVMF firmware. |
| sev_verify/output.py | Adds environment support to JSON/Markdown writers and renders an “Environment” section in Markdown. |
| sev_verify/os_info.py | Introduces host /etc/os-release parsing and guest OS detection via vsock; updates the environment dict. |
| sev_verify/environment.py | Implements best-effort host component/version detection (QEMU, kernel, OVMF, OS). |
| sev_verify/cli.py | Wires environment detection into CLI flow; updates environment with guest OS after VM launches; passes environment into outputs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
18cfd45 to
b0a9736
Compare
Quick question(s):
|
|
|
I personally like when I can also see the steps run for each test as part of the certification, just to get an idea of what's happening on each test. Do you guys think that makes the certificate too clustered?. That way also people don't necessarily need to see the source code of each test to see what's going on. I do like the additions of the environment. Also for different cert generations, do you guys think we will generate different certificates? a cert for 3.0.0, one for 3.1.0 and one for 4.0.0? |
Agree, this will be added as a part of the PR that's currently in draft - it appends the steps after this part and you'll see it in the GH issue - see amd-aliem#187 for an example.
Agree that each manifest should have its own certificate (so we'll have one GH issue per HW generation set). |
Adds host and guest environment detection to certification reports so results include the exact software versions used during the run.
None, never errors.Example Certification Formatting
Achieved Certification Level 3.0.0-1
Certified level: 3.0.0-1
Started: 2026-06-30T23:04:58.182398+00:00
Completed: 2026-06-30T23:05:13.829545+00:00
Environment
Level 3.0.0-0
Level 3.0.0-1