fix epsilon handling for signed models in sse4 - #104
Merged
Conversation
Contributor
|
I'm happy with this. Also, do you need access to the ALPS repo? |
egull
approved these changes
Jul 21, 2026
egull
left a comment
egull
left a comment
Contributor
There was a problem hiding this comment.
I'm fine with it. @skilledwolf have a look and merge provided all tests pass.
skilledwolf
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I largely followed the recommendation and set epsilon automatically to the largest diagonal element in case it is incorrectly set for models with sign, and untouched for positive models. The output is now a comment that this was changed automatically. The usage of these algorithms for models with sign is anyway very very limited. I also changed one other minor thing