Bump GitHub Actions to Node.js 24 releases - #103
Conversation
actions/checkout, actions/setup-python, actions/upload-artifact, and actions/download-artifact were pinned to versions still running on the deprecated Node.js 20 runtime. Bump to their current major releases (checkout v7, setup-python v7, upload-artifact v7, download-artifact v8), all of which run on node24.
There was a problem hiding this comment.
Pull request overview
Note
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Updates GitHub Actions workflow dependencies to newer major versions to eliminate Node.js 20 deprecation warnings from commonly used actions.
Changes:
- Bump
actions/checkouttov7in multiple workflows - Bump
actions/setup-pythontov7 - Bump artifact upload/download actions to
actions/upload-artifact@v7andactions/download-artifact@v8
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| .github/workflows/build_wheels.yml | Updates checkout/upload/download artifact action versions used by wheel/sdist build and publish jobs |
| .github/workflows/build.yml | Updates checkout/setup-python/upload-artifact action versions used by CI build/test jobs |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: actions/checkout@v7 |
| # config-file: "{package}/pyproject.toml" | ||
|
|
||
| - uses: actions/upload-artifact@v4 | ||
| - uses: actions/upload-artifact@v7 |
| if: startsWith(github.ref, 'refs/tags/v') || github.event_name == 'release' | ||
| steps: | ||
| - uses: actions/download-artifact@v4 | ||
| - uses: actions/download-artifact@v8 |
|
I call BS on the copilot comments. We won't get hacked by an upgrade of a builder, and if we do we'll have more serious problems. |
|
The packaging CI still emits the Node.js 20 deprecation warning on all three wheel builds because pypa/cibuildwheel@v2.22.0 internally invokes actions/setup-python@v5. All jobs pass, so this is not a functional failure, but it means the PR’s “no Node.js 20 deprecation warning” test-plan item is not yet satisfied. Could we either update cibuildwheel to a compatible release using setup-python@v6 or later and rerun CI, or narrow the PR description/test plan to cover only the directly referenced actions? The rest of the changes look good to me. |
|
Good point. I won't get to it before I leave, so either leave it for me for once I return or push a fix and merge, either is fine by me. |
marcusr2ML
left a comment
marcusr2ML
left a comment
There was a problem hiding this comment.
Confirmed build works and that CI passes on my end.
Still seeing the same Node.js 20 warning on Build wheels on macos-26 though, coming from setup-python@v5 pulled in by cibuildwheel@v2.22.0 (line 30 in the job log) — matches what @skilledwolf flagged.
Approving since the direct action bumps look correct and nothing's broken.
Summary
Node.js 20 is deprecatedwarnings foractions/checkout@v4andactions/upload-artifact@v4.runs.using: node24):actions/checkoutv4 -> v7actions/setup-pythonv5 -> v7actions/upload-artifactv4 -> v7actions/download-artifactv4 -> v8pip-installinput, standard name/pattern-based artifact up/download).Test plan