fix(DC0007,DC0008,DC0004): document interfaces and control add-ins - #507
fix(DC0007,DC0008,DC0004): document interfaces and control add-ins#507MODUSCarstenScholling wants to merge 5 commits into
Conversation
- Fixes ALCops#451 - Analyze registered object symbols through IObjectTypeSymbol so IInterfaceTypeSymbol and IControlAddInTypeSymbol no longer exit before documentation is checked. - Preserve the test-codeunit exemption by applying it only when the symbol also implements IApplicationObjectTypeSymbol. - Report DC0007 for undocumented public interfaces and control add-ins, and DC0008 for undocumented internal interfaces. - Add regression fixtures for the previously skipped object kinds and include them in the ObjectRequiresDocumentation test suite. - Record the SDK interface hierarchy and the intentional ControlAddIn behavior in the DC0007/DC0008 maintainer guidance. - Remove the resolved ObjectRequiresDocumentation known issue from the DC0004 procedure-documentation guidance.
Resolves the DC0004 rule-doc conflict against the restructured .claude rules and brings both DocumentationCop rule docs onto the new template: DC0004 records the control add-in procedure and event decisions and drops the resolved DC0007/DC0008 known issue; the new DC0007/DC0008 doc gets the test-folder glob, deliberate non-reports, SDK facts and test notes sections. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
Review of #507 — document interfaces and control add-ins Solid, well-scoped fix; the object-level 1. DC0004 message is inaccurate for control add-in events (and procedures).
It is not a procedure, and control add-in members take no 2. Missing NoDiagnostic regression for documented interfaces/control add-ins (object rule). 3. The parameterized-event path is untested. Every control add-in event fixture is parameterless, so 4. 5. Minor: display-text duplication. Nothing here is a crash; items 1–2 are the ones I'd want resolved before merge. |
…s-Analyzers into dev-451-dc0007+dc0008-itf+addin
- Fixes ALCops#451 - Report undocumented control add-in event declarations with DC0009 while retaining DC0004 for control add-in procedures. - Remove the unavailable local/internal remediation from the DC0004 message and use public-event wording for DC0009. - Add documented interface and control add-in object regressions plus a parameterized control add-in event fixture. - Remove the vacuous DC0006 control add-in fixture and document the corrected diagnostic routing.
Summary
Fixes #451
local/internalremediation from the public-procedure diagnostic.IObjectTypeSymbol.IApplicationObjectTypeSymbol.